New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covered dense cables #3030

Merged
merged 8 commits into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@yueh
Member

yueh commented Aug 13, 2017

It is still missing recipes for now.

The current recipe path is quartz fiber -> glass cable -> covered cable -> ( smart cable OR dense smart cable )

Adding a simple 4 smart -> 1 dense smart would make it 4x times more expensive than crafting it directly from covered cables.

A simple solution would be to always consider the smart ones as sidestep and the main path would be quartz fiber -> glass -> covered -> dense. But then no upgrade path from normal smart to dense smart ones.

{
return this.cableItem( parts.cableDenseCovered(), itemName.substring( itemName.indexOf( '.' ) + 1 ) );
}
if( itemName.equals( "cable_dense_smart" ) )

This comment has been minimized.

@orod-org

orod-org Aug 15, 2017

MINOR Move the "cable_dense_smart" string literal on the left side of this string comparison. rule

@orod-org

orod-org Aug 15, 2017

MINOR Move the "cable_dense_smart" string literal on the left side of this string comparison. rule

This comment has been minimized.

@fscan

fscan Aug 15, 2017

Member

shouldn't this be ResolverResultSet( "cable_dense_covered" .. ?

@fscan

fscan Aug 15, 2017

Member

shouldn't this be ResolverResultSet( "cable_dense_covered" .. ?

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 16, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 17, 2017

SonarQube analysis reported 23 issues

  • CRITICAL 8 critical
  • MAJOR 9 major
  • MINOR 3 minor
  • INFO 3 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL CableBusBakedModel.java#L135: The Cyclomatic Complexity of this method "isStraightLine" is 11 which is greater than 10 authorized. rule
  2. CRITICAL P2PTunnelRegistry.java#L117: Define a constant instead of duplicating this literal "enderio" 4 times. rule
  3. CRITICAL P2PTunnelRegistry.java#L132: Define a constant instead of duplicating this literal "extrautilities" 3 times. rule
  4. CRITICAL P2PTunnelRegistry.java#L133: Define a constant instead of duplicating this literal "mekanism" 4 times. rule
  5. CRITICAL P2PTunnelRegistry.java#L135: Define a constant instead of duplicating this literal "duct_32" 4 times. rule
  6. CRITICAL P2PTunnelRegistry.java#L156: Define a constant instead of duplicating this literal "duct_16" 4 times. rule
  7. CRITICAL P2PTunnelRegistry.java#L211: Remove this "Nullable" annotation to honor the overridden method's contract. rule
  8. CRITICAL P2PTunnelRegistry.java#L213: The Cyclomatic Complexity of this method "getTunnelTypeByItem" is 11 which is greater than 10 authorized. rule
  9. MAJOR P2PTunnelRegistry.java#L193: Remove this expression which always evaluates to "false" rule
  10. MAJOR P2PTunnelRegistry.java#L217: This block of commented-out lines of code should be removed. rule

orod-org commented Aug 17, 2017

SonarQube analysis reported 23 issues

  • CRITICAL 8 critical
  • MAJOR 9 major
  • MINOR 3 minor
  • INFO 3 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL CableBusBakedModel.java#L135: The Cyclomatic Complexity of this method "isStraightLine" is 11 which is greater than 10 authorized. rule
  2. CRITICAL P2PTunnelRegistry.java#L117: Define a constant instead of duplicating this literal "enderio" 4 times. rule
  3. CRITICAL P2PTunnelRegistry.java#L132: Define a constant instead of duplicating this literal "extrautilities" 3 times. rule
  4. CRITICAL P2PTunnelRegistry.java#L133: Define a constant instead of duplicating this literal "mekanism" 4 times. rule
  5. CRITICAL P2PTunnelRegistry.java#L135: Define a constant instead of duplicating this literal "duct_32" 4 times. rule
  6. CRITICAL P2PTunnelRegistry.java#L156: Define a constant instead of duplicating this literal "duct_16" 4 times. rule
  7. CRITICAL P2PTunnelRegistry.java#L211: Remove this "Nullable" annotation to honor the overridden method's contract. rule
  8. CRITICAL P2PTunnelRegistry.java#L213: The Cyclomatic Complexity of this method "getTunnelTypeByItem" is 11 which is greater than 10 authorized. rule
  9. MAJOR P2PTunnelRegistry.java#L193: Remove this expression which always evaluates to "false" rule
  10. MAJOR P2PTunnelRegistry.java#L217: This block of commented-out lines of code should be removed. rule

@yueh yueh merged commit b61219e into rv5-1.12 Aug 17, 2017

3 of 4 checks passed

sonarqube SonarQube reported 23 issues, with 8 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the feature-covered-dense-cables branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment