New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC2 rework to avoid a coremod or @Optional #3034

Merged
merged 4 commits into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Aug 16, 2017

Updated IC2 dependency

Refactored IC2 itemcharging to use an IBackupElectricManager.
Allows charging any ae powered item by using an IBackupElectricManager
instead of having to implement IElectricItem and stripping it by some
sort.

Updated IAEItemPowerStorage to use Actionable for an easier handling
with power APIs supporting a simulation.

Refactored EU P2P to avoid method stripping
Use a modified internal BasicSinkSource instead of implementing
IEnergySource and IEnergySink directly on the tunnel.

Removed the superfluous EU P2P layers.

Note this will already disable charging items via RF due to dropping the intermediate AERootPoweredItem/AEBasePoweredItem.

IC2 rework to avoid a coremod or @optional
Updated IC2 dependency

Refactored IC2 itemcharging to use an IBackupElectricManager.
Allows charging any ae powered item by using an IBackupElectricManager
instead of having to implement IElectricItem and stripping it by some
sort.

Updated IAEItemPowerStorage to use Actionable for an easier handling
with power APIs supporting a simulation.

Refactored EU P2P to avoid method stripping
Use a modified internal BasicSinkSource instead of implementing
IEnergySource and IEnergySink directly on the tunnel.

Removed the superfluous EU P2P layers.

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 16, 2017

@@ -240,12 +240,6 @@ public void initialize( @Nonnull final FMLInitializationEvent event, @Nonnull fi
// final Runnable recipeLoader = new RecipeLoader( recipeDirectory, customRecipeConfig, this.recipeHandler );

This comment has been minimized.

@orod-org

orod-org Aug 16, 2017

MAJOR This block of commented-out lines of code should be removed. rule

@orod-org

orod-org Aug 16, 2017

MAJOR This block of commented-out lines of code should be removed. rule

@Override
public void chargeFromArmor( ItemStack stack, EntityLivingBase entity )
{
// TODO Auto-generated method stub

This comment has been minimized.

@orod-org

orod-org Aug 16, 2017

INFO Complete the task associated to this TODO comment. rule

@orod-org

orod-org Aug 16, 2017

INFO Complete the task associated to this TODO comment. rule

yueh added some commits Aug 16, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 16, 2017

SonarQube analysis reported 20 issues

  • CRITICAL 4 critical
  • MAJOR 9 major
  • MINOR 5 minor
  • INFO 2 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ApiBlocks.java#L284: Define a constant instead of duplicating this literal "sky_stone_chest" 3 times. rule
  2. CRITICAL ApiBlocks.java#L343: Define a constant instead of duplicating this literal "quantum_ring" 3 times. rule
  3. CRITICAL ApiBlocks.java#L427: Define a constant instead of duplicating this literal "crafting_unit" 4 times. rule
  4. CRITICAL ApiBlocks.java#L439: Define a constant instead of duplicating this literal "crafting_storage" 4 times. rule
  5. MAJOR Registration.java#L128: Add a constructor to the class. rule
  6. MAJOR Registration.java#L150: This block of commented-out lines of code should be removed. rule
  7. MAJOR Registration.java#L238: This block of commented-out lines of code should be removed. rule
  8. MAJOR Registration.java#L248: This block of commented-out lines of code should be removed. rule
  9. MAJOR Registration.java#L345: This block of commented-out lines of code should be removed. rule
  10. MAJOR Registration.java#L355: This block of commented-out lines of code should be removed. rule

orod-org commented Aug 16, 2017

SonarQube analysis reported 20 issues

  • CRITICAL 4 critical
  • MAJOR 9 major
  • MINOR 5 minor
  • INFO 2 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ApiBlocks.java#L284: Define a constant instead of duplicating this literal "sky_stone_chest" 3 times. rule
  2. CRITICAL ApiBlocks.java#L343: Define a constant instead of duplicating this literal "quantum_ring" 3 times. rule
  3. CRITICAL ApiBlocks.java#L427: Define a constant instead of duplicating this literal "crafting_unit" 4 times. rule
  4. CRITICAL ApiBlocks.java#L439: Define a constant instead of duplicating this literal "crafting_storage" 4 times. rule
  5. MAJOR Registration.java#L128: Add a constructor to the class. rule
  6. MAJOR Registration.java#L150: This block of commented-out lines of code should be removed. rule
  7. MAJOR Registration.java#L238: This block of commented-out lines of code should be removed. rule
  8. MAJOR Registration.java#L248: This block of commented-out lines of code should be removed. rule
  9. MAJOR Registration.java#L345: This block of commented-out lines of code should be removed. rule
  10. MAJOR Registration.java#L355: This block of commented-out lines of code should be removed. rule

@yueh yueh merged commit 4f9fd1b into rv5-1.12 Aug 17, 2017

3 of 4 checks passed

sonarqube SonarQube reported 20 issues, with 4 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the feature-ic2-rework branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment