New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glowing charged quartz #3035

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Aug 16, 2017

fixes #2428

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 16, 2017

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ApiBlocks.java#L285: Define a constant instead of duplicating this literal "sky_stone_chest" 3 times. rule
  2. CRITICAL ApiBlocks.java#L344: Define a constant instead of duplicating this literal "quantum_ring" 3 times. rule
  3. CRITICAL ApiBlocks.java#L429: Define a constant instead of duplicating this literal "crafting_unit" 4 times. rule
  4. CRITICAL ApiBlocks.java#L441: Define a constant instead of duplicating this literal "crafting_storage" 4 times. rule
  5. MAJOR ApiBlocks.java#L539: Call "Optional#isPresent()" before accessing the value. rule
  6. INFO ApiBlocks.java#L497: Complete the task associated to this TODO comment. rule

orod-org commented Aug 16, 2017

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ApiBlocks.java#L285: Define a constant instead of duplicating this literal "sky_stone_chest" 3 times. rule
  2. CRITICAL ApiBlocks.java#L344: Define a constant instead of duplicating this literal "quantum_ring" 3 times. rule
  3. CRITICAL ApiBlocks.java#L429: Define a constant instead of duplicating this literal "crafting_unit" 4 times. rule
  4. CRITICAL ApiBlocks.java#L441: Define a constant instead of duplicating this literal "crafting_storage" 4 times. rule
  5. MAJOR ApiBlocks.java#L539: Call "Optional#isPresent()" before accessing the value. rule
  6. INFO ApiBlocks.java#L497: Complete the task associated to this TODO comment. rule

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 17, 2017

@yueh yueh merged commit 098ee2f into AppliedEnergistics:rv5-1.12 Aug 17, 2017

2 of 3 checks passed

sonarqube SonarQube reported 6 issues, with 4 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details

thiakil added a commit to thiakil/Applied-Energistics-2 that referenced this pull request Oct 1, 2017

Making charged certus ore glow again (AppliedEnergistics#3035)
(cherry picked from commit 098ee2f)

# Conflicts:
#	src/main/java/appeng/core/api/definitions/ApiBlocks.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment