New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P Tunnel fix #3039

Merged
merged 7 commits into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Aug 17, 2017

cleanup FE Tunnel and fix tunnels resetting to ME

}
if( this.outputTarget != null && this.outputTarget.canReceive() )
catch( GridAccessException e )

This comment has been minimized.

@orod-org

orod-org Aug 17, 2017

MAJOR Either log or rethrow this exception. rule

@orod-org

orod-org Aug 17, 2017

MAJOR Either log or rethrow this exception. rule

@@ -115,7 +140,7 @@ public int receiveEnergy( int maxReceive, boolean simulate )
total += received;
}
this.queueTunnelDrain( PowerUnits.RF, total );
PartP2PFEPower.this.queueTunnelDrain( PowerUnits.RF, total );
}
catch( GridAccessException ignored )

This comment has been minimized.

@orod-org

orod-org Aug 17, 2017

MAJOR Either log or rethrow this exception. rule

@orod-org

orod-org Aug 17, 2017

MAJOR Either log or rethrow this exception. rule

@@ -115,7 +140,7 @@ public int receiveEnergy( int maxReceive, boolean simulate )
total += received;
}
this.queueTunnelDrain( PowerUnits.RF, total );
PartP2PFEPower.this.queueTunnelDrain( PowerUnits.RF, total );
}
catch( GridAccessException ignored )
{

This comment has been minimized.

@orod-org

orod-org Aug 17, 2017

MAJOR Either remove or fill this block of code. rule

@orod-org

orod-org Aug 17, 2017

MAJOR Either remove or fill this block of code. rule

fscan added some commits Aug 17, 2017

total += t.getAttachedEnergyStorage().getEnergyStored();
}
}
catch( GridAccessException e )

This comment has been minimized.

@orod-org

orod-org Aug 17, 2017

MAJOR Either log or rethrow this exception. rule

@orod-org

orod-org Aug 17, 2017

MAJOR Either log or rethrow this exception. rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 17, 2017

SonarQube analysis reported 5 issues

  • MAJOR 5 major

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR PartP2PTunnel.java#L218: Remove this expression which always evaluates to "true" rule

orod-org commented Aug 17, 2017

SonarQube analysis reported 5 issues

  • MAJOR 5 major

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR PartP2PTunnel.java#L218: Remove this expression which always evaluates to "true" rule

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 17, 2017

@yueh yueh merged commit 8e4265a into AppliedEnergistics:rv5-1.12 Aug 17, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 5 issues, no criticals or blockers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment