New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SCS size to the Spatial IO Port. #3045

Merged
merged 1 commit into from Aug 20, 2017

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Aug 19, 2017

Uses the same format as the cells display in their tooltip for easy comparsion.

Added SCS size to the Spatial IO Port.
Uses the same format as the cells display in their tooltip for easy
comparsion.

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 19, 2017

final DimensionalCoord min = sc.getMin();
final DimensionalCoord max = sc.getMax();
if( min != null && max != null && sc.isValidRegion() )

This comment has been minimized.

@orod-org

orod-org Aug 19, 2017

CRITICAL Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule

@orod-org

orod-org Aug 19, 2017

CRITICAL Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule

@@ -114,6 +114,8 @@
MaxPower,
RequiredPower,
Efficiency,
SCSSize,

This comment has been minimized.

@orod-org

orod-org Aug 19, 2017

CRITICAL Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule

@orod-org

orod-org Aug 19, 2017

CRITICAL Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 19, 2017

SonarQube analysis reported 3 issues

  • CRITICAL 3 critical

Watch the comments in this conversation to review them.

orod-org commented Aug 19, 2017

SonarQube analysis reported 3 issues

  • CRITICAL 3 critical

Watch the comments in this conversation to review them.

@@ -114,6 +114,8 @@
MaxPower,
RequiredPower,
Efficiency,
SCSSize,
SCSSInvalid,

This comment has been minimized.

@orod-org

orod-org Aug 19, 2017

CRITICAL Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule

@orod-org

orod-org Aug 19, 2017

CRITICAL Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule

@yueh yueh merged commit a1679c9 into rv5-1.12 Aug 20, 2017

3 of 4 checks passed

sonarqube SonarQube reported 3 issues, with 3 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the feature-spatial-io-port-scs-size branch Aug 20, 2017

thiakil added a commit to thiakil/Applied-Energistics-2 that referenced this pull request Oct 1, 2017

Added SCS size to the Spatial IO Port. (#3045)
Uses the same format as the cells display in their tooltip for easy comparison.
(cherry picked from commit a1679c9)

# Conflicts:
#	src/main/java/appeng/client/gui/implementations/GuiSpatialIOPort.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment