Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Performance improvements for the energygrid #3051
Reworked the old recursive approach to a queue based loop.
This replaces the old not really working buffer with a special
Currently it set to hold a maximum of 1000 AE (+ optional overflow until
1000 AE is certainl excessive for a local storage in nearly all cases. Around 10 to 100 would certainly be more fitting. But a local network with 8 drives full of 64k cells will extract about 180 AE per tick, which should be about the amount a local buffer should provide to avoid reaching out to energy cells in other grids. Thus 200 AE might be fine.
Another idea might be to link it to the idle drain. So every gridnode would add/remove their idle draw to the maximum on top off a small buffer to accomendate for the energy use by channels.
SonarQube analysis reported 17 issues
Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here: