New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard inheritance to propagage NBT events #3058

Merged
merged 4 commits into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Aug 26, 2017

The custom event system is not really needed and makes ordering semi-random.

{
this.markForUpdate();
}
}
private final boolean readFromStream( final ByteBuf data )
protected boolean readFromStream( final ByteBuf data ) throws IOException

This comment has been minimized.

@orod-org

orod-org Aug 26, 2017

MINOR Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. rule

@orod-org

orod-org Aug 26, 2017

MINOR Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. rule

return false;
}
protected void writeToStream( final ByteBuf data ) throws IOException

This comment has been minimized.

@orod-org

orod-org Aug 26, 2017

MINOR Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. rule

@orod-org

orod-org Aug 26, 2017

MINOR Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. rule

@yueh yueh added this to the rv5.alpha - 1.12 milestone Aug 26, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Aug 27, 2017

SonarQube analysis reported 29 issues

  • CRITICAL 1 critical
  • MAJOR 11 major
  • MINOR 17 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEBaseTile.java#L411: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  2. MAJOR AEBaseTile.java#L354: Remove this unused method parameter "player". rule
  3. MAJOR AEBaseTile.java#L368: Remove this unused method parameter "from". rule
  4. MAJOR AEBaseTile.java#L428: Remove this unused method parameter "from". rule
  5. MAJOR TileCellWorkbench.java#L235: Remove this expression which always evaluates to "true" rule
  6. MAJOR TileWireless.java#L162: Change this condition so that it does not always evaluate to "false" rule
  7. MAJOR AEBasePoweredTile.java#L103: Remove this unused method parameter "maxRequired". rule
  8. MAJOR AEBasePoweredTile.java#L273: Remove this conditional structure or edit its code blocks so that they're not all the same. rule
  9. MAJOR AEBasePoweredTile.java#L282: Merge this if statement with the enclosing one. rule
  10. MAJOR AEBasePoweredTile.java#L304: Merge this if statement with the enclosing one. rule

orod-org commented Aug 27, 2017

SonarQube analysis reported 29 issues

  • CRITICAL 1 critical
  • MAJOR 11 major
  • MINOR 17 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEBaseTile.java#L411: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  2. MAJOR AEBaseTile.java#L354: Remove this unused method parameter "player". rule
  3. MAJOR AEBaseTile.java#L368: Remove this unused method parameter "from". rule
  4. MAJOR AEBaseTile.java#L428: Remove this unused method parameter "from". rule
  5. MAJOR TileCellWorkbench.java#L235: Remove this expression which always evaluates to "true" rule
  6. MAJOR TileWireless.java#L162: Change this condition so that it does not always evaluate to "false" rule
  7. MAJOR AEBasePoweredTile.java#L103: Remove this unused method parameter "maxRequired". rule
  8. MAJOR AEBasePoweredTile.java#L273: Remove this conditional structure or edit its code blocks so that they're not all the same. rule
  9. MAJOR AEBasePoweredTile.java#L282: Merge this if statement with the enclosing one. rule
  10. MAJOR AEBasePoweredTile.java#L304: Merge this if statement with the enclosing one. rule

@yueh yueh merged commit 548af3c into AppliedEnergistics:rv5-1.12 Aug 28, 2017

2 of 3 checks passed

sonarqube SonarQube reported 29 issues, with 1 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment