Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactored the BaseActionSource #3063
It now uses an interface instead of a concrete class and further subclasses.
Instead of relying on a specific class for a certain action type, it now uses methods with Optional as return values to determine a player or machine issuing an action.
IActionHost no longer extends IGridHost. It never used the additional functionality and if needed the IGridNode will also provide a reference to the corresponding IGridHost.
SonarQube analysis reported 59 issues
Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
Currently no, but mostly because the changes are still a bit experimental and open up one or two code paths, which could create issues in some very rare cases. If they will more likely happen in an established modpack, thus it is not a good idea should we have to revert a stable version because of it.
If there was more testing done/time passed without issues showing, it might be an idea to backport it. But then it is always the question of 1.10 being still relevant at that point.
Sep 12, 2017
Hi yueh, thank you for considering 1.10 for this fix.