New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve terminal search box #3064

Merged
merged 2 commits into from Sep 16, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Aug 31, 2017

Always remember last search. Copy JEI search box text if available.

@@ -587,7 +579,6 @@ protected boolean checkHotbarKeys( final int keyCode )
public void onGuiClosed()

This comment has been minimized.

@orod-org

orod-org Aug 31, 2017

MINOR Remove this method to simply inherit it. rule

@orod-org

orod-org Aug 31, 2017

MINOR Remove this method to simply inherit it. rule

@yueh yueh added this to the rv5.alpha - 1.12 milestone Sep 9, 2017

Rework terminal search
change color

some QoL improvements and code cleanup

always set intial focus to textbox

testing ui

ui testing

restore old gui

cleanup
endY = j;
}
startY -= PADDING;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startY". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startY". rule

if( startX < endX )
{
int i = startX;
startX = endX;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startX". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startX". rule

{
int i = startX;
startX = endX;
endX = i;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endX". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endX". rule

if( endX > this.x + this.width )
{
endX = this.x + this.width;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endX". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endX". rule

endX = i;
}
startX += 1;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startX". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startX". rule

}
startX += 1;
endX -= 1;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endX". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endX". rule

if( startX > this.x + this.width )
{
startX = this.x + this.width;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startX". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startX". rule

if( startY < endY )
{
int j = startY;
startY = endY;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startY". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "startY". rule

{
int j = startY;
startY = endY;
endY = j;

This comment has been minimized.

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endY". rule

@orod-org

orod-org Sep 12, 2017

MINOR Introduce a new variable instead of reusing the parameter "endY". rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Sep 16, 2017

SonarQube analysis reported 11 issues

  • CRITICAL 1 critical
  • MINOR 10 minor

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GuiMEMonitorable.java#L355: Make the enclosing method "static" or remove this set. rule

orod-org commented Sep 16, 2017

SonarQube analysis reported 11 issues

  • CRITICAL 1 critical
  • MINOR 10 minor

Watch the comments in this conversation to review them.

1 extra issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GuiMEMonitorable.java#L355: Make the enclosing method "static" or remove this set. rule

@yueh yueh merged commit 4dd0a4c into AppliedEnergistics:rv5-1.12 Sep 16, 2017

2 of 3 checks passed

sonarqube SonarQube reported 11 issues, with 1 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment