Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rework AEItemStack #3091
First draft, simple tests seem to work.
This gets rid of the custom AEItemDef and uses ItemStack for it. Deduplication/Sharing is done at ItemStack level instead of NBTTagCompund, this may be less optimal but by using ItemStack we get the benefit of correctly handling caps and other future stuff mc/forge introduces.
SonarQube analysis reported 83 issues
Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here: