New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UVLLoader a bit more robust #3102

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Sep 21, 2017

Catch all parsing exceptions instead of propagating them upwards as these are meaningless for the actual test.
Renamed uvlMarker to ae2_uvl_marker just in case some other mod uses the same key.

Make UVLLoader a bit more robust
Catch all parsing exceptions instead of propagating them upwards as
these are meaningless for the actual test.
Renamed uvlMarker to ae2_uvl_marker just in case some other mod uses the
same key.

@yueh yueh added this to the rv5.alpha - 1.12 milestone Sep 21, 2017

@@ -387,7 +389,7 @@ public void setQuadTint( int tint )
class UVLMarker
{
boolean uvlMarker = false;
boolean ae2_uvl_marker = false;

This comment has been minimized.

@orod-org

orod-org Sep 21, 2017

MINOR Rename this field "ae2_uvl_marker" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@orod-org

orod-org Sep 21, 2017

MINOR Rename this field "ae2_uvl_marker" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Sep 21, 2017

SonarQube analysis reported 5 issues

  • MINOR 5 minor

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR UVLModelLoader.java#L123: Remove this use of "propagate"; it is deprecated. rule
  2. MINOR UVLModelLoader.java#L138: Remove this use of "propagate"; it is deprecated. rule
  3. MINOR UVLModelLoader.java#L150: Remove this use of "propagate"; it is deprecated. rule
  4. MINOR UVLModelLoader.java#L162: Remove this use of "propagate"; it is deprecated. rule

orod-org commented Sep 21, 2017

SonarQube analysis reported 5 issues

  • MINOR 5 minor

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR UVLModelLoader.java#L123: Remove this use of "propagate"; it is deprecated. rule
  2. MINOR UVLModelLoader.java#L138: Remove this use of "propagate"; it is deprecated. rule
  3. MINOR UVLModelLoader.java#L150: Remove this use of "propagate"; it is deprecated. rule
  4. MINOR UVLModelLoader.java#L162: Remove this use of "propagate"; it is deprecated. rule

@yueh yueh merged commit 829c18e into rv5-1.12 Sep 21, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 5 issues, no criticals or blockers

@yueh yueh deleted the fix-uvl-loader-robustness branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment