New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved IGrinderRegistry #3110

Merged
merged 2 commits into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Sep 23, 2017

Added a builder for grinder recipes similar to IInscriberRegistry.
Replaced different add methods with this builder.
IIinscriberRegistry#addRecipe and removeRecipe now return true on success.

Improved IGrinderRegistry
Added a builder for grinder recipes similar to IInscriberRegistry.
Replaced different add methods with this builder.
IIinscriberRegistry#addRecipe and removeRecipe now return true on success.

@yueh yueh added this to the rv5.alpha - 1.12 milestone Sep 23, 2017

* Internal {@link IInscriberRecipeBuilder} implementation.
* Needs to be adapted to represent a correct {@link IInscriberRecipe}
*/
private static final class Builder implements IGrinderRecipeBuilder

This comment has been minimized.

@orod-org

orod-org Sep 23, 2017

MAJOR Add a constructor to the class. rule

@orod-org

orod-org Sep 23, 2017

MAJOR Add a constructor to the class. rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Sep 23, 2017

SonarQube analysis reported 1 issue

  • MAJOR 1 major

Watch the comments in this conversation to review them.

orod-org commented Sep 23, 2017

SonarQube analysis reported 1 issue

  • MAJOR 1 major

Watch the comments in this conversation to review them.

@yueh yueh merged commit 2ed7a55 into rv5-1.12 Sep 29, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 1 issue, no criticals or blockers

@yueh yueh deleted the feature-improved-grinderregistry branch Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment