New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional TE wrench support. #3145

Merged
merged 2 commits into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Oct 8, 2017

No description provided.

fscan added some commits Oct 8, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 8, 2017

SonarQube analysis reported 8 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. BLOCKER Platform.java#L1407: Refactor this method to not always return the same value. rule
  2. MAJOR ToolNetworkTool.java#L143: Remove this unused method parameter "is". rule
  3. MAJOR Platform.java#L579: Remove this useless assignment to local variable "itemStack". rule
  4. MAJOR Platform.java#L624: Remove this useless assignment to local variable "itemStack". rule
  5. MAJOR Platform.java#L1413: Call "Optional#isPresent()" before accessing the value. rule
  6. MAJOR Platform.java#L1417: Call "Optional#isPresent()" before accessing the value. rule
  7. MAJOR Platform.java#L1612: This block of commented-out lines of code should be removed. rule
  8. MINOR Platform.java#L436: Remove this use of "getDrops"; it is deprecated. rule

orod-org commented Oct 8, 2017

SonarQube analysis reported 8 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. BLOCKER Platform.java#L1407: Refactor this method to not always return the same value. rule
  2. MAJOR ToolNetworkTool.java#L143: Remove this unused method parameter "is". rule
  3. MAJOR Platform.java#L579: Remove this useless assignment to local variable "itemStack". rule
  4. MAJOR Platform.java#L624: Remove this useless assignment to local variable "itemStack". rule
  5. MAJOR Platform.java#L1413: Call "Optional#isPresent()" before accessing the value. rule
  6. MAJOR Platform.java#L1417: Call "Optional#isPresent()" before accessing the value. rule
  7. MAJOR Platform.java#L1612: This block of commented-out lines of code should be removed. rule
  8. MINOR Platform.java#L436: Remove this use of "getDrops"; it is deprecated. rule

@yueh yueh merged commit 8ad8ce6 into rv5-1.12 Oct 8, 2017

3 of 4 checks passed

sonarqube SonarQube reported 8 issues, with 1 blocker
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the feature-te-wrench branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment