New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further StorageChannel refactoring #3152

Merged
merged 1 commit into from Oct 14, 2017

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Oct 11, 2017

Updated Drives to support more than Item and Fluid cells.
Use Collections.emptyList() instead of creating empty ArrayLists.
Fixes a NPE with uninitialized ME Chests.

Fixes #3150

Further StorageChannel refactoring
Updated Drives to support more than Item and Fluid cells.
Use Collections.emptyList() instead of creating empty ArrayLists.
Fixes a NPE with uninitialized ME Chests.

Fixes #3150

@yueh yueh added this to the rv5.alpha - 1.12 milestone Oct 11, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 11, 2017

SonarQube analysis reported 10 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR TileChest.java#L276: Change this condition so that it does not always evaluate to "false" rule
  2. MAJOR TileChest.java#L722: Remove this unused method parameter "side". rule
  3. MINOR PartStorageBus.java#L22: Remove this unused import 'java.util.Arrays'. rule
  4. MINOR TileChest.java#L23: Remove this unused import 'java.util.ArrayList'. rule
  5. MINOR TileChest.java#L125: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  6. MINOR TileChest.java#L126: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  7. MINOR TileChest.java#L287: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  8. MINOR TileChest.java#L297: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  9. MINOR TileChest.java#L838: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  10. MINOR TileChest.java#L843: Remove this use of "MEMonitorHandler"; it is deprecated. rule

orod-org commented Oct 11, 2017

SonarQube analysis reported 10 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR TileChest.java#L276: Change this condition so that it does not always evaluate to "false" rule
  2. MAJOR TileChest.java#L722: Remove this unused method parameter "side". rule
  3. MINOR PartStorageBus.java#L22: Remove this unused import 'java.util.Arrays'. rule
  4. MINOR TileChest.java#L23: Remove this unused import 'java.util.ArrayList'. rule
  5. MINOR TileChest.java#L125: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  6. MINOR TileChest.java#L126: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  7. MINOR TileChest.java#L287: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  8. MINOR TileChest.java#L297: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  9. MINOR TileChest.java#L838: Remove this use of "MEMonitorHandler"; it is deprecated. rule
  10. MINOR TileChest.java#L843: Remove this use of "MEMonitorHandler"; it is deprecated. rule

@yueh yueh merged commit ab7f35a into rv5-1.12 Oct 14, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 10 issues, no criticals or blockers

@yueh yueh deleted the feature-further-storagechannel-refactoring branch Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment