New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some API and related cleanups #3155

Merged
merged 3 commits into from Oct 14, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Oct 12, 2017

No description provided.

*
* TODO: Needs to be redesigned to solve performance issues. Also should not be part of the API as class.
* TODO: Needs to be redesigned to solve performance issues.

This comment has been minimized.

@orod-org

orod-org Oct 12, 2017

INFO Complete the task associated to this TODO comment. rule

@orod-org

orod-org Oct 12, 2017

INFO Complete the task associated to this TODO comment. rule

@@ -31,5 +31,5 @@
String getPattern( RecipeHandler han );
boolean canCraft( ItemStack output ) throws RegistrationError, MissingIngredientError;
boolean canCraft( ItemStack output ) throws RegistrationException, MissingIngredientException;

This comment has been minimized.

@orod-org

orod-org Oct 12, 2017

MAJOR Refactor this method to throw at most one checked exception instead of: appeng.api.exceptions.RegistrationException, appeng.api.exceptions.MissingIngredientException rule

@orod-org

orod-org Oct 12, 2017

MAJOR Refactor this method to throw at most one checked exception instead of: appeng.api.exceptions.RegistrationException, appeng.api.exceptions.MissingIngredientException rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 12, 2017

SonarQube analysis reported 22 issues

  • CRITICAL 3 critical
  • MAJOR 11 major
  • MINOR 4 minor
  • INFO 4 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEBaseMEGui.java#L102: The Cyclomatic Complexity of this method "renderToolTip" is 11 which is greater than 10 authorized. rule
  2. CRITICAL CableBusBakedModel.java#L135: The Cyclomatic Complexity of this method "isStraightLine" is 12 which is greater than 10 authorized. rule
  3. CRITICAL AEBaseContainer.java#L224: The Cyclomatic Complexity of this method "setTargetStack" is 11 which is greater than 10 authorized. rule
  4. MAJOR GridNode.java#L617: A "List" cannot contain a "IPathItem" rule
  5. MAJOR CraftingGridCache.java#L203: A "Set" cannot contain a "IGridHost" rule
  6. MAJOR CraftingGridCache.java#L487: Iterate over the "entrySet" instead of the "keySet". rule
  7. MAJOR InscriberProcess.java#L101: Use "Integer.toString" instead. rule
  8. MAJOR Shaped.java#L110: Remove this useless assignment to local variable "outIS". rule
  9. MAJOR Shaped.java#L115: This block of commented-out lines of code should be removed. rule
  10. MAJOR Shapeless.java#L73: Remove this useless assignment to local variable "outIS". rule

orod-org commented Oct 12, 2017

SonarQube analysis reported 22 issues

  • CRITICAL 3 critical
  • MAJOR 11 major
  • MINOR 4 minor
  • INFO 4 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEBaseMEGui.java#L102: The Cyclomatic Complexity of this method "renderToolTip" is 11 which is greater than 10 authorized. rule
  2. CRITICAL CableBusBakedModel.java#L135: The Cyclomatic Complexity of this method "isStraightLine" is 12 which is greater than 10 authorized. rule
  3. CRITICAL AEBaseContainer.java#L224: The Cyclomatic Complexity of this method "setTargetStack" is 11 which is greater than 10 authorized. rule
  4. MAJOR GridNode.java#L617: A "List" cannot contain a "IPathItem" rule
  5. MAJOR CraftingGridCache.java#L203: A "Set" cannot contain a "IGridHost" rule
  6. MAJOR CraftingGridCache.java#L487: Iterate over the "entrySet" instead of the "keySet". rule
  7. MAJOR InscriberProcess.java#L101: Use "Integer.toString" instead. rule
  8. MAJOR Shaped.java#L110: Remove this useless assignment to local variable "outIS". rule
  9. MAJOR Shaped.java#L115: This block of commented-out lines of code should be removed. rule
  10. MAJOR Shapeless.java#L73: Remove this useless assignment to local variable "outIS". rule

@yueh yueh merged commit 4f07b63 into rv5-1.12 Oct 14, 2017

3 of 4 checks passed

sonarqube SonarQube reported 22 issues, with 3 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the api-cleanup branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment