New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advancements! #3160

Merged
merged 8 commits into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@fscan
Member

fscan commented Oct 14, 2017

Glass cable only detects fluix cable at the moment.
IPlayerRegistry#findPlayer may be a problem.

fscan added some commits Oct 14, 2017

static class Listeners
{
private final PlayerAdvancements playerAdvancements;
private final Set<ICriterionTrigger.Listener<AppEngAdvancementTrigger.Instance>> listeners = new HashSet<>();

This comment has been minimized.

@orod-org

orod-org Oct 14, 2017

MAJOR Rename field "listeners" rule

@orod-org

orod-org Oct 14, 2017

MAJOR Rename field "listeners" rule

this.listeners.remove( listener );
}
public void trigger( EntityPlayerMP player )

This comment has been minimized.

@orod-org

orod-org Oct 14, 2017

MAJOR Remove this unused method parameter "player". rule

@orod-org

orod-org Oct 14, 2017

MAJOR Remove this unused method parameter "player". rule

public class AppEngAdvancementTrigger implements ICriterionTrigger<AppEngAdvancementTrigger.Instance>, IAdvancementTrigger
{
private final ResourceLocation ID;

This comment has been minimized.

@orod-org

orod-org Oct 14, 2017

MINOR Rename this field "ID" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@orod-org

orod-org Oct 14, 2017

MINOR Rename this field "ID" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

for( final IGridNode n : this.requireChannels )
{
players.add( n.getPlayerID() );
EntityPlayer player = AEApi.instance().registries().players().findPlayer( n.getPlayerID() );
if( player instanceof EntityPlayerMP )

This comment has been minimized.

@orod-org

orod-org Oct 14, 2017

CRITICAL Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule

@orod-org

orod-org Oct 14, 2017

CRITICAL Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 18, 2017

SonarQube analysis reported 16 issues

  • CRITICAL 2 critical
  • MAJOR 11 major
  • MINOR 3 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GuiMEMonitorable.java#L362: Make the enclosing method "static" or remove this set. rule
  2. MAJOR Registration.java#L138: Add a constructor to the class. rule
  3. MAJOR Registration.java#L162: This block of commented-out lines of code should be removed. rule
  4. MAJOR Registration.java#L250: Remove this useless assignment to local variable "partHelper". rule
  5. MAJOR Registration.java#L261: This block of commented-out lines of code should be removed. rule
  6. MAJOR Registration.java#L356: This block of commented-out lines of code should be removed. rule
  7. MAJOR Registration.java#L490: This block of commented-out lines of code should be removed. rule
  8. MAJOR PathGridCache.java#L317: A "HashSet" cannot contain a "IGridNode" rule
  9. MAJOR TileChest.java#L275: Change this condition so that it does not always evaluate to "false" rule
  10. MAJOR TileChest.java#L721: Remove this unused method parameter "side". rule

orod-org commented Oct 18, 2017

SonarQube analysis reported 16 issues

  • CRITICAL 2 critical
  • MAJOR 11 major
  • MINOR 3 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GuiMEMonitorable.java#L362: Make the enclosing method "static" or remove this set. rule
  2. MAJOR Registration.java#L138: Add a constructor to the class. rule
  3. MAJOR Registration.java#L162: This block of commented-out lines of code should be removed. rule
  4. MAJOR Registration.java#L250: Remove this useless assignment to local variable "partHelper". rule
  5. MAJOR Registration.java#L261: This block of commented-out lines of code should be removed. rule
  6. MAJOR Registration.java#L356: This block of commented-out lines of code should be removed. rule
  7. MAJOR Registration.java#L490: This block of commented-out lines of code should be removed. rule
  8. MAJOR PathGridCache.java#L317: A "HashSet" cannot contain a "IGridNode" rule
  9. MAJOR TileChest.java#L275: Change this condition so that it does not always evaluate to "false" rule
  10. MAJOR TileChest.java#L721: Remove this unused method parameter "side". rule

@fscan fscan merged commit cc9b33b into rv5-1.12 Oct 20, 2017

3 of 4 checks passed

sonarqube SonarQube reported 16 issues, with 2 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the feature-1.12-advancements branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment