New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NBT ordering in ItemList #3169

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@fscan
Member

fscan commented Oct 20, 2017

Fixes rare insertion/extraction errors with items only differentiated by NBT.

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 20, 2017

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEBaseContainer.java#L224: The Cyclomatic Complexity of this method "setTargetStack" is 11 which is greater than 10 authorized. rule
  2. CRITICAL AESharedItemStack.java#L72: Define a constant instead of duplicating this literal "ItemStack#getCount() has to be 1" 6 times. rule
  3. CRITICAL AESharedItemStack.java#L146: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. CRITICAL AESharedItemStack.java#L186: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. MAJOR AESharedItemStack.java#L146: Remove this conditional structure or edit its code blocks so that they're not all the same. rule
  6. MINOR AESharedItemStack.java#L42: Redundant 'public' modifier. rule

orod-org commented Oct 20, 2017

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEBaseContainer.java#L224: The Cyclomatic Complexity of this method "setTargetStack" is 11 which is greater than 10 authorized. rule
  2. CRITICAL AESharedItemStack.java#L72: Define a constant instead of duplicating this literal "ItemStack#getCount() has to be 1" 6 times. rule
  3. CRITICAL AESharedItemStack.java#L146: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. CRITICAL AESharedItemStack.java#L186: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. MAJOR AESharedItemStack.java#L146: Remove this conditional structure or edit its code blocks so that they're not all the same. rule
  6. MINOR AESharedItemStack.java#L42: Redundant 'public' modifier. rule

@fscan fscan merged commit f80f623 into rv5-1.12 Oct 20, 2017

2 of 4 checks passed

sonarqube SonarQube reported 6 issues, with 4 critical
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the fix-nbt-comparison branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment