New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always sync full NBT for AEItemStack #3171

Merged
merged 5 commits into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Oct 21, 2017

Fixes Terminal issues with synching ItemStacks using the share tag (eg Bag of Holding).

fscan added some commits Oct 21, 2017

Introduce a server side ID for shared ItemStacks to restore full NBT …
…data.

Fixes issues with synching ItemStacks using the share tag.

@fscan fscan changed the title from Introduce a server side ID for shared ItemStacks to Always sync full NBT for AEItemStack Oct 21, 2017

@yueh yueh added this to the rv5.beta- 1.12 milestone Oct 24, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 26, 2017

SonarQube analysis reported 8 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AESharedItemStack.java#L77: Define a constant instead of duplicating this literal "ItemStack#getCount() has to be 1" 6 times. rule
  2. CRITICAL AESharedItemStack.java#L161: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  3. CRITICAL AESharedItemStack.java#L201: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. MAJOR AEItemStack.java#L103: A "NullPointerException" could be thrown; "item" is nullable here. rule
  5. MAJOR AESharedItemStack.java#L161: Remove this conditional structure or edit its code blocks so that they're not all the same. rule
  6. MINOR AEFluidStack.java#L292: Remove this unnecessary cast to "NBTTagCompound". rule
  7. MINOR AESharedItemStack.java#L42: Redundant 'public' modifier. rule
  8. INFO AEFluidStack.java#L349: Complete the task associated to this TODO comment. rule

orod-org commented Oct 26, 2017

SonarQube analysis reported 8 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AESharedItemStack.java#L77: Define a constant instead of duplicating this literal "ItemStack#getCount() has to be 1" 6 times. rule
  2. CRITICAL AESharedItemStack.java#L161: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  3. CRITICAL AESharedItemStack.java#L201: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. MAJOR AEItemStack.java#L103: A "NullPointerException" could be thrown; "item" is nullable here. rule
  5. MAJOR AESharedItemStack.java#L161: Remove this conditional structure or edit its code blocks so that they're not all the same. rule
  6. MINOR AEFluidStack.java#L292: Remove this unnecessary cast to "NBTTagCompound". rule
  7. MINOR AESharedItemStack.java#L42: Redundant 'public' modifier. rule
  8. INFO AEFluidStack.java#L349: Complete the task associated to this TODO comment. rule

@fscan fscan merged commit 3749742 into rv5-1.12 Oct 26, 2017

3 of 4 checks passed

sonarqube SonarQube reported 8 issues, with 3 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the feature-aestack-sync branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment