New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extraction for Condenser #3179

Merged
merged 4 commits into from Oct 27, 2017

Conversation

Projects
None yet
4 participants
@fscan
Member

fscan commented Oct 26, 2017

fixes #2960, fixes #2017, fixes #2602

@mindforger

This comment has been minimized.

Show comment
Hide comment
@mindforger

mindforger Oct 27, 2017

Collaborator

and maybe even those

#2017
#2602
maybe have a look at #1350 too in this case to make it complete?

and i've read something about possible balancing or default item routing issues in some of the closed ones, maybe add an testing session :)

Collaborator

mindforger commented Oct 27, 2017

and maybe even those

#2017
#2602
maybe have a look at #1350 too in this case to make it complete?

and i've read something about possible balancing or default item routing issues in some of the closed ones, maybe add an testing session :)

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 27, 2017

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TileCondenser.java#L112: Cast one of the operands of this multiplication operation to a "double". rule

orod-org commented Oct 27, 2017

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TileCondenser.java#L112: Cast one of the operands of this multiplication operation to a "double". rule

@fscan fscan merged commit 2c07acf into rv5-1.12 Oct 27, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 1 issue, no criticals or blockers

@fscan fscan deleted the feature-condenser-extract branch Oct 27, 2017

@mrossleslie

This comment has been minimized.

Show comment
Hide comment
@mrossleslie

mrossleslie Dec 29, 2017

Can this fix be pushed to 1.10, please?

mrossleslie commented Dec 29, 2017

Can this fix be pushed to 1.10, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment