New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Facade rendering #3182

Merged
merged 4 commits into from Oct 29, 2017

Conversation

Projects
None yet
2 participants
@fscan
Member

fscan commented Oct 28, 2017

UV fix based on #2941 by @MoreThanHidden
fixes #2679, fixes #2625

@@ -251,6 +257,51 @@ private UvVector getDefaultUv( EnumFacing face, TextureAtlasSprite texture, floa
return uv;
}
private UvVector getStandardUv( EnumFacing face, TextureAtlasSprite texture, float x1, float y1, float z1, float x2, float y2, float z2 )

This comment has been minimized.

@orod-org

orod-org Oct 28, 2017

MAJOR Method has 8 parameters, which is greater than 7 authorized. rule

@orod-org

orod-org Oct 28, 2017

MAJOR Method has 8 parameters, which is greater than 7 authorized. rule

}
@Override
public ItemCameraTransforms getItemCameraTransforms()

This comment has been minimized.

@orod-org

orod-org Oct 28, 2017

MINOR Don't override a deprecated method or explicitly mark it as "@deprecated". rule

@orod-org

orod-org Oct 28, 2017

MINOR Don't override a deprecated method or explicitly mark it as "@deprecated". rule

@Override
public ItemCameraTransforms getItemCameraTransforms()
{
return this.baseModel.getItemCameraTransforms();

This comment has been minimized.

@orod-org

orod-org Oct 28, 2017

MINOR Remove this use of "getItemCameraTransforms"; it is deprecated. rule

@orod-org

orod-org Oct 28, 2017

MINOR Remove this use of "getItemCameraTransforms"; it is deprecated. rule

@fscan

This comment has been minimized.

Show comment
Hide comment
@fscan

fscan Oct 29, 2017

Member

Still some issues:

  1. when block emits light shading gets disabled (eg: terminal part). Not sure what to do about it.
  2. blocks with multiple texture layers (eg: some chisel blocks) only use the first texture. Would have to render the quads into a buffer and use that as a texture. Not exactly sure how hard it would be.
Member

fscan commented Oct 29, 2017

Still some issues:

  1. when block emits light shading gets disabled (eg: terminal part). Not sure what to do about it.
  2. blocks with multiple texture layers (eg: some chisel blocks) only use the first texture. Would have to render the quads into a buffer and use that as a texture. Not exactly sure how hard it would be.
@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 29, 2017

SonarQube analysis reported 7 issues

  • CRITICAL 1 critical
  • MAJOR 1 major
  • MINOR 5 minor

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL CableBusBakedModel.java#L135: The Cyclomatic Complexity of this method "isStraightLine" is 12 which is greater than 10 authorized. rule
  2. MINOR BlockCableBus.java#L188: Don't override a deprecated method or explicitly mark it as "@deprecated". rule
  3. MINOR CableBusBakedModel.java#L361: Don't override a deprecated method or explicitly mark it as "@deprecated". rule
  4. MINOR CubeBuilder.java#L338: Declare "v" on a separate line. rule

orod-org commented Oct 29, 2017

SonarQube analysis reported 7 issues

  • CRITICAL 1 critical
  • MAJOR 1 major
  • MINOR 5 minor

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL CableBusBakedModel.java#L135: The Cyclomatic Complexity of this method "isStraightLine" is 12 which is greater than 10 authorized. rule
  2. MINOR BlockCableBus.java#L188: Don't override a deprecated method or explicitly mark it as "@deprecated". rule
  3. MINOR CableBusBakedModel.java#L361: Don't override a deprecated method or explicitly mark it as "@deprecated". rule
  4. MINOR CubeBuilder.java#L338: Declare "v" on a separate line. rule

@fscan fscan merged commit 6ddf60f into rv5-1.12 Oct 29, 2017

3 of 4 checks passed

sonarqube SonarQube reported 7 issues, with 1 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the fix-facades branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment