New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic cache for cable models to avoid constant regeneration. #3185

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Oct 29, 2017

No description provided.

@yueh yueh added this to the rv5.beta- 1.12 milestone Oct 29, 2017

final CableBusRenderState other = (CableBusRenderState) obj;
return this.cableColor == other.cableColor && this.cableType == other.cableType && this.coreType == other.coreType && Objects

This comment has been minimized.

@orod-org

orod-org Oct 31, 2017

CRITICAL Reduce the number of conditional operators (6) used in the expression (maximum allowed 3). rule

@orod-org

orod-org Oct 31, 2017

CRITICAL Reduce the number of conditional operators (6) used in the expression (maximum allowed 3). rule

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Oct 31, 2017

SonarQube analysis reported 3 issues

  • CRITICAL 2 critical
  • MINOR 1 minor

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL CableBusBakedModel.java#L145: The Cyclomatic Complexity of this method "isStraightLine" is 12 which is greater than 10 authorized. rule
  2. MINOR CableBusBakedModel.java#L369: Don't override a deprecated method or explicitly mark it as "@deprecated". rule

orod-org commented Oct 31, 2017

SonarQube analysis reported 3 issues

  • CRITICAL 2 critical
  • MINOR 1 minor

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL CableBusBakedModel.java#L145: The Cyclomatic Complexity of this method "isStraightLine" is 12 which is greater than 10 authorized. rule
  2. MINOR CableBusBakedModel.java#L369: Don't override a deprecated method or explicitly mark it as "@deprecated". rule

@yueh yueh merged commit cc4599b into rv5-1.12 Oct 31, 2017

3 of 4 checks passed

sonarqube SonarQube reported 3 issues, with 2 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the fix-2521 branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment