Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial IO improvements #3195

Merged
merged 3 commits into from Nov 4, 2017
Merged

Spatial IO improvements #3195

merged 3 commits into from Nov 4, 2017

Conversation

@fscan
Copy link
Member

@fscan fscan commented Nov 4, 2017

Fixes a crash with ITickable TileEntities.

{
public IBlockState state;

This comment has been minimized.

@orod-org

orod-org Nov 4, 2017

MINOR Make state a static final constant or non-public and provide accessors if needed. rule

{
public IBlockState state;
public int light;

This comment has been minimized.

@orod-org

orod-org Nov 4, 2017

MINOR Make light a static final constant or non-public and provide accessors if needed. rule

@orod-org
Copy link

@orod-org orod-org commented Nov 4, 2017

SonarQube analysis reported 2 issues

  • MINOR 2 minor

Watch the comments in this conversation to review them.

@fscan fscan merged commit fe5d925 into rv5-1.12 Nov 4, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 2 issues, no criticals or blockers
@fscan fscan deleted the fix-spatial-misc branch Nov 5, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants