New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic CraftTweaker support #3231

Merged
merged 13 commits into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@fscan
Member

fscan commented Nov 16, 2017

supports Grinder and Inscriber

fscan added some commits Nov 16, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Nov 22, 2017

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL IntegrationType.java#L44: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  2. CRITICAL IntegrationType.java#L66: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  3. MINOR AppEng.java#L76: Make this "public static proxy" field final rule

orod-org commented Nov 22, 2017

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL IntegrationType.java#L44: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  2. CRITICAL IntegrationType.java#L66: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  3. MINOR AppEng.java#L76: Make this "public static proxy" field final rule

@fscan fscan merged commit 959672d into rv5-1.12 Nov 22, 2017

3 of 4 checks passed

sonarqube SonarQube reported 3 issues, with 2 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the feature-crafttweaker branch Dec 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment