New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert DamageableRecipe changes #3246

Merged
merged 1 commit into from Nov 26, 2017

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Nov 22, 2017

Forge fixed this after all. This is no longer needed.

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Nov 22, 2017

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR _factories.json#: Rename this file to match this regular expression: ^[A-Za-z][-_A-Za-z0-9]*.json$ rule

orod-org commented Nov 22, 2017

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR _factories.json#: Rename this file to match this regular expression: ^[A-Za-z][-_A-Za-z0-9]*.json$ rule

@fscan fscan added this to the rv5.stable - 1.12 milestone Nov 22, 2017

@yueh yueh merged commit 3063bd8 into rv5-1.12 Nov 26, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 1 issue, no criticals or blockers

@fscan fscan deleted the revert-damagable branch Dec 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment