New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a debug generator for ForgeEnergy. #3259

Merged
merged 2 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Dec 1, 2017

This adds a simple debug block to test external energy injection via
ForgeEnergy and not rely solely on creative cells.

The energy has two functions. The first is acting as an infinite
ForgEnergy battery, this is unused by AE2 itself as nothing pulls
energy.
The second on is injecting energy every tick into any adjacent block
accepting ForgeEnergy.
The base generation is 8 per tick, but this is increased by the power of
adjacent TileEnergyGenerators.


Table for generation per tick. 6 adjacent generators is possible, but then there is nothing to actually inject.

#adjacentGenerators ForgeEnergy/tick
0 8
1 64
2 512
3 4096
4 32768
5 262144
Adds a debug generator for ForgeEnergy.
This adds a simple debug block to test external energy injection via
ForgeEnergy and not rely solely on creative cells.

The energy has two functions. The first is acting as an infinite
ForgEnergy battery, this is unused by AE2 itself as nothing pulls
energy.
The second on is injecting energy every tick into any adjacent block
accepting ForgeEnergy.
The base generation is 8 per tick, but this is increased by the power of
adjacent TileEnergyGenerators.

@yueh yueh added this to the rv5.stable - 1.12 milestone Dec 1, 2017

@orod-org

This comment has been minimized.

Show comment
Hide comment
@orod-org

orod-org Dec 20, 2017

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ApiBlocks.java#L288: Define a constant instead of duplicating this literal "sky_stone_chest" 3 times. rule
  2. CRITICAL ApiBlocks.java#L347: Define a constant instead of duplicating this literal "quantum_ring" 3 times. rule
  3. CRITICAL ApiBlocks.java#L431: Define a constant instead of duplicating this literal "crafting_unit" 4 times. rule
  4. CRITICAL ApiBlocks.java#L443: Define a constant instead of duplicating this literal "crafting_storage" 4 times. rule
  5. MAJOR ApiBlocks.java#L546: Call "Optional#isPresent()" before accessing the value. rule
  6. INFO ApiBlocks.java#L499: Complete the task associated to this TODO comment. rule

orod-org commented Dec 20, 2017

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ApiBlocks.java#L288: Define a constant instead of duplicating this literal "sky_stone_chest" 3 times. rule
  2. CRITICAL ApiBlocks.java#L347: Define a constant instead of duplicating this literal "quantum_ring" 3 times. rule
  3. CRITICAL ApiBlocks.java#L431: Define a constant instead of duplicating this literal "crafting_unit" 4 times. rule
  4. CRITICAL ApiBlocks.java#L443: Define a constant instead of duplicating this literal "crafting_storage" 4 times. rule
  5. MAJOR ApiBlocks.java#L546: Call "Optional#isPresent()" before accessing the value. rule
  6. INFO ApiBlocks.java#L499: Complete the task associated to this TODO comment. rule

@yueh yueh merged commit e243c8e into rv5-1.12 Dec 21, 2017

3 of 4 checks passed

sonarqube SonarQube reported 6 issues, with 4 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the feature-debug-energy-generator branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment