Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Reworked IO Port to handle StorageChannels better. #3284
The IO Port is currently limited to items and potentially fluids, but no 3rd party storage channel. Which should be fixed by this PR.
It also introduces a new default method for
Due to being a default method, it should not break backward compatibility, but there might be some issues with forward compatibility should some 3rd party addon make use of it and someone combines it with an earlier AE2 version.
SonarQube analysis reported 16 issues
Watch the comments in this conversation to review them.
9 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
There is still a small issue with EC2 fluid cells, which will be moved to the output after the first type was transfered. Only happens when set to
But this seems to be an EC2 bug, as it fails on extracting the item from their handler.