New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Grid API #3399

Merged
merged 2 commits into from May 27, 2018

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Feb 22, 2018

Added Nonull/Nullable/Nonnegative where applicable.
Deprecated unused methods
Changed concrete classes with interfaces (HashMap -> Map)
IGridTickable will no longer accept null as TickingRequest. Do not
implement it, if it should not tick.

@yueh yueh added this to the rv6.alpha - 1.12 milestone Feb 22, 2018

*/
@Deprecated
void setNetworkStatus( IGrid grid, int channelsInUse );

This comment has been minimized.

@orod-org

orod-org Feb 22, 2018

INFO Do not forget to remove this deprecated code someday. rule

@@ -24,6 +24,9 @@
package appeng.api.networking.crafting;
import javax.annotation.Nonnull;
public interface ICraftingCallback

This comment has been minimized.

@orod-org

orod-org Feb 22, 2018

CRITICAL Annotate the "ICraftingCallback" interface with the @FunctionalInterface annotation rule

@yueh yueh force-pushed the e-grid-api branch from 9e242c0 to 913f078 Mar 22, 2018

yueh added some commits Feb 22, 2018

Updated Grid API
Added Nonull/Nullable/Nonnegative where applicable.
Deprecated unused methods
Changed concrete classes with interfaces (HashMap -> Map)
IGridTickable will no longer accept null as TickingRequest. Do not
implement it, if it should not tick.

@yueh yueh force-pushed the e-grid-api branch from f94f32a to 0d27981 May 27, 2018

@orod-org

This comment has been minimized.

orod-org commented May 27, 2018

SonarQube analysis reported 7 issues

  • CRITICAL 6 critical
  • INFO 1 info

Watch the comments in this conversation to review them.

5 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL IGridVisitor.java#L33: Annotate the "IGridVisitor" interface with the @FunctionalInterface annotation rule
  2. CRITICAL IEnergySource.java#L34: Annotate the "IEnergySource" interface with the @FunctionalInterface annotation rule
  3. CRITICAL IActionHost.java#L32: Annotate the "IActionHost" interface with the @FunctionalInterface annotation rule
  4. CRITICAL ISecurityRegistry.java#L37: Annotate the "ISecurityRegistry" interface with the @FunctionalInterface annotation rule
  5. CRITICAL TileSecurityStation.java#L115: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule

@yueh yueh merged commit 044e639 into rv6-1.12 May 27, 2018

3 of 4 checks passed

sonarqube SonarQube reported 7 issues, with 6 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the e-grid-api branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment