New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a simple warning to patterns when using CraftingManager fallback. #3412

Merged
merged 2 commits into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Mar 5, 2018

No description provided.

@yueh yueh added this to the rv5.stable - 1.12 milestone Mar 5, 2018

@orod-org

This comment has been minimized.

orod-org commented Mar 6, 2018

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR PatternHelper.java#L79: Move the declaration of "outTag" closer to the code that uses it. rule
  2. MAJOR PatternHelper.java#L87: Move the declaration of "out" closer to the code that uses it. rule

@yueh yueh merged commit 6c7cbb7 into rv5-1.12 Mar 8, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
sonarqube SonarQube reported 2 issues, no criticals or blockers

@yueh yueh deleted the e-pattern-craftingmanager-logging branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment