New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config option to disable the CraftingManager fallback. #3415

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@yueh
Member

yueh commented Mar 6, 2018

Using the CraftingManager to find an alternative recipe can be a bit costly as it scales with the amount of mods/recipes.

In general this should probably be avoided at all. If a mod adds alternative recipes e.g. a unique one for every single oredict equivalent or for different NBT data, it is clearly a bad decision on their side.

Therefore it will be enabled for backwards compatibility in rv5, but disabled by default in rv6.
In case of no major issues resulting from disabling it, it is scheduled to be completely removed in 1.13.

@yueh yueh added this to the rv5.stable - 1.12 milestone Mar 6, 2018

@yueh yueh force-pushed the e-option-craftingmanager-fallback branch from c8f8244 to 6e6248b Mar 8, 2018

@orod-org

This comment has been minimized.

orod-org commented Mar 8, 2018

SonarQube analysis reported 10 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEConfig.java#L256: Define a constant instead of duplicating this literal "spatialio" 6 times. rule
  2. CRITICAL AEFeature.java#L95: Use already-defined constant 'CATEGORY_PORTABLE_CELL' instead of duplicating its value here. rule
  3. CRITICAL AEFeature.java#L103: Use already-defined constant 'CATEGORY_NETWORK_TOOL' instead of duplicating its value here. rule
  4. CRITICAL AEFeature.java#L129: Use already-defined constant 'CATEGORY_FACADES' instead of duplicating its value here. rule
  5. CRITICAL PatternHelper.java#L234: The Cyclomatic Complexity of this method "isValidItemForSlot" is 11 which is greater than 10 authorized. rule
  6. MAJOR PatternHelper.java#L81: Move the declaration of "outTag" closer to the code that uses it. rule
  7. MAJOR PatternHelper.java#L89: Move the declaration of "out" closer to the code that uses it. rule
  8. MINOR AEConfig.java#L366: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  9. MINOR AEConfig.java#L371: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  10. MINOR AEConfig.java#L376: Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@yueh yueh merged commit ccefb47 into rv5-1.12 Mar 8, 2018

2 of 4 checks passed

sonarqube SonarQube reported 10 issues, with 5 critical
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the e-option-craftingmanager-fallback branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment