Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces all custom number comparisons with java provided ones. #3434

Merged
merged 1 commit into from May 27, 2018

Conversation

@yueh
Copy link
Member

@yueh yueh commented Mar 19, 2018

No description provided.

@yueh yueh added this to the rv6.alpha - 1.12 milestone Mar 19, 2018
@yueh yueh force-pushed the e-remove-custom-number-comparisons branch from 734b39a to 3001229 Mar 22, 2018
@yueh yueh mentioned this pull request May 24, 2018
BrockWS added a commit to BrockWS/Applied-Energistics-2 that referenced this pull request May 27, 2018
Removed the fluid storage housing.
Implemented AppliedEnergistics#3434 for FluidSorters
@yueh yueh force-pushed the e-remove-custom-number-comparisons branch from 3001229 to 46bdcb1 May 27, 2018
@yueh yueh force-pushed the e-remove-custom-number-comparisons branch from 46bdcb1 to 7afdf03 May 27, 2018
@orod-org
Copy link

@orod-org orod-org commented May 27, 2018

SonarQube analysis reported 22 issues

  • CRITICAL 2 critical
  • MAJOR 18 major
  • INFO 2 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL PatternHelper.java#L233: The Cyclomatic Complexity of this method "isValidItemForSlot" is 11 which is greater than 10 authorized. rule
  2. CRITICAL NetworkInventoryHandler.java#L78: The Cyclomatic Complexity of this method "injectItems" is 15 which is greater than 10 authorized. rule
  3. MAJOR PatternHelper.java#L80: Move the declaration of "outTag" closer to the code that uses it. rule
  4. MAJOR PatternHelper.java#L88: Move the declaration of "out" closer to the code that uses it. rule
  5. MAJOR ToolColorApplicator.java#L309: Remove this call to "equals"; comparisons between unrelated types always return false. rule
  6. MAJOR CraftingGridCache.java#L95: Make this anonymous inner class a lambda rule
  7. MAJOR CraftingGridCache.java#L106: Make this anonymous inner class a lambda rule
  8. MAJOR CraftingGridCache.java#L202: A "Set" cannot contain a "IGridHost" rule
  9. MAJOR CraftingGridCache.java#L292: Extract the assignment out of this expression. rule
  10. MAJOR CraftingGridCache.java#L486: Iterate over the "entrySet" instead of the "keySet". rule
@yueh yueh merged commit 2894a7c into rv6-1.12 May 27, 2018
3 of 4 checks passed
3 of 4 checks passed
@orod-org
sonarqube SonarQube reported 22 issues, with 2 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@yueh
jenkins Success
Details
@yueh yueh deleted the e-remove-custom-number-comparisons branch Jun 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants