Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with Fluid Channel not being sent changes. #3504

Merged
merged 1 commit into from Jun 17, 2018

Conversation

@BrockWS
Copy link
Contributor

@BrockWS BrockWS commented May 21, 2018

When a cell is removed from a ME Drive/Chest, any fluid channel changes are not being sent to watchers.
This is a fix for ExtraCells/ExtraCells2#560

@yueh
Copy link
Member

@yueh yueh commented May 24, 2018

This really needs a better solution at some point as it potentially affects any custom storage channel.

@BrockWS
Copy link
Contributor Author

@BrockWS BrockWS commented May 24, 2018

Could change it so it loops through all channels and call postAlterationOfStoredItems for each channel?

@yueh yueh added this to the rv6.alpha - 1.12 milestone May 30, 2018
@yueh yueh changed the base branch from rv5-1.12 to rv6-1.12 May 30, 2018
@orod-org
Copy link

@orod-org orod-org commented May 30, 2018

SonarQube analysis reported 21 issues

  • CRITICAL 4 critical
  • MAJOR 11 major
  • MINOR 6 minor

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Platform.java#L514: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  2. CRITICAL Platform.java#L1440: The Cyclomatic Complexity of this method "extractItemsByRecipe" is 21 which is greater than 10 authorized. rule
  3. CRITICAL Platform.java#L1458: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. CRITICAL Platform.java#L1474: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. MAJOR Platform.java#L514: Merge this if statement with the enclosing one. rule
  6. MAJOR Platform.java#L575: Remove this useless assignment to local variable "itemStack". rule
  7. MAJOR Platform.java#L620: Remove this useless assignment to local variable "itemStack". rule
  8. MAJOR Platform.java#L1120: This branch's code block is the same as the block for the branch on line 1116. rule
  9. MAJOR Platform.java#L1302: This branch's code block is the same as the block for the branch on line 1298. rule
  10. MAJOR Platform.java#L1357: Change this condition so that it does not always evaluate to "false" rule
@yueh yueh merged commit dcd94b1 into AppliedEnergistics:rv6-1.12 Jun 17, 2018
2 of 3 checks passed
2 of 3 checks passed
sonarqube SonarQube reported 21 issues, with 4 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.