Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fluid models #3543

Merged
merged 1 commit into from Jun 17, 2018
Merged

Added fluid models #3543

merged 1 commit into from Jun 17, 2018

Conversation

@yueh
Copy link
Member

@yueh yueh commented Jun 17, 2018

No description provided.

@yueh yueh added this to the rv6.alpha - 1.12 milestone Jun 17, 2018
@@ -47,15 +47,15 @@
import appeng.client.me.FluidRepo;
import appeng.client.me.SlotFluidME;
import appeng.client.me.InternalFluidSlotME;

This comment has been minimized.

@orod-org

orod-org Jun 17, 2018

MINOR Wrong order for 'appeng.client.me.InternalFluidSlotME' import. rule

@orod-org
Copy link

@orod-org orod-org commented Jun 17, 2018

SonarQube analysis reported 39 issues

  • BLOCKER 6 blocker
  • CRITICAL 14 critical
  • MAJOR 13 major
  • MINOR 5 minor
  • INFO 1 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. BLOCKER PacketMEFluidInventoryUpdate.java#L86: Use try-with-resources or close this "GZIPInputStream" in a "finally" clause. rule
  2. BLOCKER PacketTargetFluidStack.java#: Add or update the header of this file. rule
  3. BLOCKER GuiFluidStorageBus.java#: Add or update the header of this file. rule
  4. BLOCKER GuiFluidTerminal.java#: Add or update the header of this file. rule
  5. BLOCKER ContainerFluidStorageBus.java#: Add or update the header of this file. rule
  6. BLOCKER ContainerFluidTerminal.java#: Add or update the header of this file. rule
  7. CRITICAL ContainerUpgradeable.java#L248: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  8. CRITICAL PacketValueConfig.java#L189: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  9. CRITICAL PacketValueConfig.java#L200: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  10. CRITICAL GuiFluidTerminal.java#L245: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
@yueh yueh merged commit 2c6e50d into rv6-1.12 Jun 17, 2018
3 of 4 checks passed
3 of 4 checks passed
sonarqube SonarQube reported 39 issues, with 14 critical and 6 blocker
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
@yueh yueh deleted the e-fluid-part-models branch Jun 17, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.