Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slot shift-clicking to generate correct onChangeInventory events #3544

Merged
merged 1 commit into from Jun 18, 2018

Conversation

@fscan
Copy link
Member

@fscan fscan commented Jun 17, 2018

This should fix #3492

@orod-org
Copy link

@orod-org orod-org commented Jun 17, 2018

SonarQube analysis reported 11 issues

  • CRITICAL 10 critical
  • MAJOR 1 major

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEBaseContainer.java#L698: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  2. CRITICAL AEBaseContainer.java#L710: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  3. CRITICAL AEBaseContainer.java#L721: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. CRITICAL AEBaseContainer.java#L761: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. CRITICAL AEBaseContainer.java#L831: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  6. CRITICAL AEBaseContainer.java#L855: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  7. CRITICAL AEBaseContainer.java#L859: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  8. CRITICAL AEBaseContainer.java#L967: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  9. CRITICAL AEBaseContainer.java#L1006: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  10. CRITICAL AEBaseContainer.java#L1099: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
@yueh yueh merged commit 41e7558 into rv5-1.12 Jun 18, 2018
3 of 4 checks passed
3 of 4 checks passed
sonarqube SonarQube reported 11 issues, with 10 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
@yueh yueh added this to the rv5.stable - 1.12 milestone Jul 1, 2018
@fscan fscan deleted the fix-slot-shift-click branch Jul 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.