Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fluid interface GUI and other fluid related textures. #3567

Merged
merged 1 commit into from Jun 27, 2018

Conversation

@yueh
Copy link
Member

@yueh yueh commented Jun 27, 2018

No description provided.

@yueh yueh added this to the rv6.alpha - 1.12 milestone Jun 27, 2018
@@ -43,6 +43,7 @@
FluidInterface,
Config,
StoredItems,
StoredFluids,
Patterns,
ImportBus,
ImportBusFluids,

This comment has been minimized.

@orod-org

orod-org Jun 27, 2018

CRITICAL Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule

@@ -43,6 +43,7 @@
FluidInterface,

This comment has been minimized.

@orod-org

orod-org Jun 27, 2018

CRITICAL Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule

@@ -43,6 +43,7 @@
FluidInterface,
Config,
StoredItems,
StoredFluids,

This comment has been minimized.

@orod-org

orod-org Jun 27, 2018

CRITICAL Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule

@orod-org
Copy link

@orod-org orod-org commented Jun 27, 2018

SonarQube analysis reported 27 issues

  • CRITICAL 14 critical
  • MAJOR 9 major
  • MINOR 4 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GuiText.java#L51: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  2. CRITICAL GuiText.java#L57: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  3. CRITICAL GuiText.java#L72: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  4. CRITICAL GuiText.java#L98: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  5. CRITICAL GuiText.java#L103: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  6. CRITICAL GuiText.java#L126: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  7. CRITICAL GuiText.java#L127: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. rule
  8. CRITICAL DualityFluidInterface.java#L268: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  9. CRITICAL DualityFluidInterface.java#L378: The Cyclomatic Complexity of this method "usePlan" is 13 which is greater than 10 authorized. rule
  10. CRITICAL DualityFluidInterface.java#L401: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
@yueh yueh merged commit dcf7de9 into rv6-1.12 Jun 27, 2018
3 of 4 checks passed
3 of 4 checks passed
sonarqube SonarQube reported 27 issues, with 14 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details
@yueh yueh deleted the e-fluid-textures branch Jun 27, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.