New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh_cn.lang #3570

Merged
merged 7 commits into from Nov 17, 2018

Conversation

Projects
None yet
3 participants
@xsun2001
Copy link
Contributor

xsun2001 commented Jun 28, 2018

Update zh_cn.lang

xsun2001 added some commits Jun 28, 2018

@Metric-Void

This comment has been minimized.

Copy link

Metric-Void commented Oct 18, 2018

This request did fix some translation errors and should be merged asap.
Good job.

@xsun2001

This comment has been minimized.

Copy link
Contributor

xsun2001 commented Oct 19, 2018

Thanks @Metric-Void .
However, I do think that AE2 develops don't want to make any change on L18N, as the other L18N pull requests are not be merged yet. @yueh could you take the time to deal with it?

@Metric-Void

This comment has been minimized.

Copy link

Metric-Void commented Oct 19, 2018

Well, they’re not closing it. Maybe they just haven’t seen this. (For this long)

@yueh

This comment has been minimized.

Copy link
Member

yueh commented Nov 11, 2018

Basically it's not ideal to merge localizations before the strings are really stable. It just causes translators constantly having to update it in case something needs a change.

Also please do no translate comments, they are mostly for us devs to quickly locate a certain section. If really needed, at least preserve the normal one and just append the translation.
E.g. something like // foobar (translation)

xsun2001 added some commits Nov 17, 2018

@xsun2001

This comment has been minimized.

Copy link
Contributor

xsun2001 commented Nov 17, 2018

Alright. I am very glad that you have noticed this. I have changed the comment back to English. And I will continue updating this translation. I want to know when these strings will stabilize, since AE has reached the fourth stable version of rv6.

@yueh

This comment has been minimized.

Copy link
Member

yueh commented Nov 17, 2018

Thanks

@yueh yueh merged commit 8e735e7 into AppliedEnergistics:rv6-1.12 Nov 17, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment