Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore behaviour of ESC always closing the GUI #3601

Merged
merged 1 commit into from Jul 14, 2018
Merged

Restore behaviour of ESC always closing the GUI #3601

merged 1 commit into from Jul 14, 2018

Conversation

@fscan
Copy link
Member

@fscan fscan commented Jul 8, 2018

Turns out to be more annoying than useful. Enter or Tab can still remove focus from the search box.

@orod-org
Copy link

@orod-org orod-org commented Jul 8, 2018

SonarQube analysis reported 11 issues

  • CRITICAL 4 critical
  • MAJOR 7 major

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GuiMEMonitorable.java#L336: Make the enclosing method "static" or remove this set. rule
  2. CRITICAL GuiMEMonitorable.java#L366: Make the enclosing method "static" or remove this set. rule
  3. CRITICAL GuiMEMonitorable.java#L367: Make the enclosing method "static" or remove this set. rule
  4. CRITICAL GuiMEMonitorable.java#L479: The Cyclomatic Complexity of this method "keyTyped" is 11 which is greater than 10 authorized. rule
  5. MAJOR GuiMEMonitorable.java#L282: Extract the assignment out of this expression. rule
  6. MAJOR GuiMEMonitorable.java#L289: Extract the assignment out of this expression. rule
  7. MAJOR GuiMEMonitorable.java#L293: Extract the assignment out of this expression. rule
  8. MAJOR GuiMEMonitorable.java#L298: Extract the assignment out of this expression. rule
  9. MAJOR GuiMEMonitorable.java#L307: Extract the assignment out of this expression. rule
  10. MAJOR GuiMEMonitorable.java#L321: Extract the assignment out of this expression. rule
@yueh yueh added this to the rv6.alpha - 1.12 milestone Jul 11, 2018
@fscan fscan merged commit e2c0129 into rv6-1.12 Jul 14, 2018
3 of 4 checks passed
3 of 4 checks passed
@orod-org
sonarqube SonarQube reported 11 issues, with 4 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@yueh
jenkins Success
Details
@fscan fscan deleted the search-box-esc branch Jul 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants