New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the colour-coded P2P frequency to the memory card. #3609

Merged
merged 13 commits into from Jul 14, 2018

Conversation

Projects
None yet
3 participants
@yueh
Member

yueh commented Jul 11, 2018

Replaces #3009

@yueh yueh added this to the rv6.alpha - 1.12 milestone Jul 11, 2018

@tyra314

This comment has been minimized.

Contributor

tyra314 commented Jul 11, 2018

I'm glad you picked it up again. I haven't checked it, but just in case you have used any code part of the previous PR, you have my full consent to use any of it as you like. 😄

@Override
public ItemOverrideList getOverrides()
{
return new ItemOverrideList( Collections.emptyList() )

This comment has been minimized.

@orod-org

orod-org Jul 12, 2018

MAJOR Reduce this anonymous class number of lines from 21 to at most 20, or make it a named class. rule

}
@Override
public ItemCameraTransforms getItemCameraTransforms()

This comment has been minimized.

@orod-org

orod-org Jul 12, 2018

MINOR Don't override a deprecated method or explicitly mark it as "@deprecated". rule

@Override
public ItemCameraTransforms getItemCameraTransforms()
{
return this.baseModel.getItemCameraTransforms();

This comment has been minimized.

@orod-org

orod-org Jul 12, 2018

MINOR Remove this use of "getItemCameraTransforms"; it is deprecated. rule

@Override
public IModelState getDefaultState()
{
return TRSRTransformation.identity().toItemTransform();

This comment has been minimized.

@orod-org

orod-org Jul 12, 2018

MINOR Remove this use of "toItemTransform"; it is deprecated. rule

}
catch( Exception e )
{
throw new RuntimeException( e );

This comment has been minimized.

@orod-org

orod-org Jul 12, 2018

MAJOR Define and throw a dedicated exception instead of using a generic one. rule

yueh added some commits Jul 13, 2018

Added cachekey to ensure no duplicate are cached.
Changed default color code  to transparent/fluix
Moved the colorcode to a generic intArray as part of the NBT data.
Allows any part/machine to encode a corresponding color code if
necessary.
final AEColor color = this.colorCode[x + y * 4];
builder.setColorRGB( color.mediumVariant );
builder.addCube( 7 + x, 8 + ( 1 - y ), 7.5f, 7 + x + 1, 8 + ( 1 - y ) + 1, 8.5f );

This comment has been minimized.

@orod-org

orod-org Jul 14, 2018

MINOR Cast one of the operands of this addition operation to a "float". rule
MINOR Cast one of the operands of this addition operation to a "float". rule
MINOR Cast one of the operands of this addition operation to a "float". rule
MINOR Cast one of the operands of this addition operation to a "float". rule

yueh added some commits Jul 14, 2018

@orod-org

This comment has been minimized.

orod-org commented Jul 14, 2018

SonarQube analysis reported 17 issues

  • BLOCKER 3 blocker
  • MAJOR 4 major
  • MINOR 10 minor

Watch the comments in this conversation to review them.

8 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. BLOCKER MemoryCardBakedModel.java#: Add or update the header of this file. rule
  2. BLOCKER MemoryCardModel.java#: Add or update the header of this file. rule
  3. BLOCKER ToolMemoryCardRendering.java#: Add or update the header of this file. rule
  4. MAJOR PartP2PTunnel.java#L205: Rename "freq" which hides the field declared at line 62. rule
  5. MAJOR PartP2PTunnel.java#L243: Remove this expression which always evaluates to "true" rule
  6. MINOR BiometricCardBakedModel.java#L163: Don't override a deprecated method or explicitly mark it as "@deprecated". rule
  7. MINOR BiometricCardBakedModel.java#L165: Remove this use of "getItemCameraTransforms"; it is deprecated. rule
  8. MINOR ApiItems.java#L245: Remove useless curly braces around statement rule

@yueh yueh merged commit fe4db2e into rv6-1.12 Jul 14, 2018

3 of 4 checks passed

sonarqube SonarQube reported 17 issues, with 3 blocker
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the e-memory-card-frequency-tooltip branch Jul 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment