New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unnecessary cell saving when cell is full #3611

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
3 participants
@BrockWS
Contributor

BrockWS commented Jul 13, 2018

No description provided.

@orod-org

This comment has been minimized.

orod-org commented Jul 13, 2018

SonarQube analysis reported 19 issues

  • CRITICAL 6 critical
  • MAJOR 11 major
  • MINOR 1 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL FluidCellInventory.java#L92: The Cyclomatic Complexity of this method "injectItems" is 14 which is greater than 10 authorized. rule
  2. CRITICAL FluidCellInventory.java#L152: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  3. CRITICAL FluidCellInventory.java#L237: Define a constant instead of duplicating this literal "Removing item " 3 times. rule
  4. CRITICAL ItemCellInventory.java#L108: The Cyclomatic Complexity of this method "injectItems" is 17 which is greater than 10 authorized. rule
  5. CRITICAL ItemCellInventory.java#L177: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  6. CRITICAL ItemCellInventory.java#L262: Define a constant instead of duplicating this literal "Removing item " 3 times. rule
  7. MAJOR FluidCellInventory.java#L66: Either log or rethrow this exception. rule
  8. MAJOR FluidCellInventory.java#L82: Merge this if statement with the enclosing one. rule
  9. MAJOR FluidCellInventory.java#L108: Move the declaration of "sharedFluidStack" closer to the code that uses it. rule
  10. MAJOR FluidCellInventory.java#L241: Catch Exception instead of Throwable. rule

@fscan fscan merged commit 7fe7f4b into AppliedEnergistics:rv6-1.12 Jul 14, 2018

2 of 3 checks passed

sonarqube SonarQube reported 19 issues, with 6 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins Success
Details

@BrockWS BrockWS deleted the BrockWS:bugfix-cells branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment