New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some deco blocks to their own feature category #3618

Merged
merged 4 commits into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@fscan
Member

fscan commented Jul 14, 2018

They are used in a lot of recipes and not just deco.

Related to #3617

.build();
this.skyStoneSmallBrick = deco.block( "sky_stone_small_brick", () -> new BlockSkyStone( SkystoneType.SMALL_BRICK ) )
.addFeatures( AEFeature.SKY_STONE )
.build();
this.skyStoneChest = registry.block( "sky_stone_chest", () -> new BlockSkyChest( SkyChestType.STONE ) )

This comment has been minimized.

@orod-org

orod-org Jul 14, 2018

CRITICAL Define a constant instead of duplicating this literal "sky_stone_chest" 3 times. rule

@@ -557,7 +568,7 @@ private static IBlockDefinition makeSlab( String slabId, String doubleSlabId, Fe
Block block = blockDef.maybeBlock().get();

This comment has been minimized.

@orod-org

orod-org Jul 14, 2018

MAJOR Call "Optional#isPresent()" before accessing the value. rule

@orod-org

This comment has been minimized.

orod-org commented Jul 14, 2018

SonarQube analysis reported 18 issues

  • CRITICAL 9 critical
  • MAJOR 4 major
  • MINOR 4 minor
  • INFO 1 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL AEConfig.java#L176: Define a constant instead of duplicating this literal "worldGen" 7 times. rule
  2. CRITICAL AEConfig.java#L263: Define a constant instead of duplicating this literal "spatialio" 6 times. rule
  3. CRITICAL ApiBlocks.java#L365: Define a constant instead of duplicating this literal "quantum_ring" 3 times. rule
  4. CRITICAL ApiBlocks.java#L453: Define a constant instead of duplicating this literal "crafting_unit" 4 times. rule
  5. CRITICAL ApiBlocks.java#L465: Define a constant instead of duplicating this literal "crafting_storage" 4 times. rule
  6. CRITICAL AEFeature.java#L104: Use already-defined constant 'CATEGORY_PORTABLE_CELL' instead of duplicating its value here. rule
  7. CRITICAL AEFeature.java#L112: Use already-defined constant 'CATEGORY_NETWORK_TOOL' instead of duplicating its value here. rule
  8. CRITICAL AEFeature.java#L137: Use already-defined constant 'CATEGORY_FACADES' instead of duplicating its value here. rule
  9. MAJOR ApiBlocks.java#L580: Call "Optional#isPresent()" before accessing the value. rule
  10. MAJOR ApiBlocks.java#L590: Call "Optional#isPresent()" before accessing the value. rule

@fscan fscan merged commit c8eb792 into rv6-1.12 Jul 14, 2018

3 of 4 checks passed

sonarqube SonarQube reported 18 issues, with 9 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the fix-quartz-glass-feature branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment