New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condensor improvements #3636

Merged
merged 2 commits into from Jul 31, 2018

Conversation

Projects
None yet
2 participants
@fscan
Member

fscan commented Jul 21, 2018

Use correct transfer factor and provide voiding for all storage channels

@@ -294,10 +296,10 @@ public int getSlotLimit( int slot )
}
}
private static final IFluidTankProperties[] EMPTY = { new FluidTankProperties( null, 10, true, false ) };
private static final IFluidTankProperties[] EMPTY = { new FluidTankProperties( null, Fluid.BUCKET_VOLUME, true, false ) };

This comment has been minimized.

@orod-org

orod-org Jul 21, 2018

MINOR Move this variable to comply with Java Code Conventions. rule

}
@Override
public IAEFluidStack injectItems( final IAEFluidStack input, final Actionable mode, final IActionSource src )
public T injectItems( final T input, final Actionable mode, final IActionSource src )

This comment has been minimized.

@orod-org

orod-org Jul 21, 2018

BLOCKER Refactor this method to not always return the same value. rule

@orod-org

This comment has been minimized.

orod-org commented Jul 21, 2018

SonarQube analysis reported 4 issues

  • BLOCKER 1 blocker
  • MAJOR 1 major
  • MINOR 2 minor

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR TileCondenser.java#L230: This branch's code block is the same as the block for the branch on line 226. rule
  2. MINOR TileCondenser.java#L114: Cast one of the operands of this multiplication operation to a "double". rule

@fscan fscan added this to the rv6.alpha - 1.12 milestone Jul 21, 2018

@fscan fscan merged commit ad1eff2 into rv6-1.12 Jul 31, 2018

3 of 4 checks passed

sonarqube SonarQube reported 4 issues, with 1 blocker
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the improve-condenser branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment