New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chest to work with any cell #3640

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
2 participants
@fscan
Member

fscan commented Jul 22, 2018

No description provided.

AEApi.instance().storage().getStorageChannel( IFluidStorageChannel.class ) );
if( itemCell != null )
for( IStorageChannel channel : AEApi.instance().storage().storageChannels() )

This comment has been minimized.

@orod-org

orod-org Jul 22, 2018

CRITICAL Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule

@@ -974,34 +837,23 @@ public IStorageMonitorable getInventory( IActionSource src )
private class FluidHandler implements IFluidHandler
{
private final IFluidTankProperties[] TANK_PROPS = new IFluidTankProperties[] { new FluidTankProperties( null, Fluid.BUCKET_VOLUME ) };

This comment has been minimized.

@orod-org

orod-org Jul 22, 2018

MINOR Rename this field "TANK_PROPS" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@orod-org

This comment has been minimized.

orod-org commented Jul 22, 2018

SonarQube analysis reported 8 issues

  • CRITICAL 1 critical
  • MAJOR 3 major
  • MINOR 4 minor

Watch the comments in this conversation to review them.

6 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR TileChest.java#L224: Rename "cellHandler" which hides the field declared at line 123. rule
  2. MAJOR TileChest.java#L754: Remove this expression which always evaluates to "true" rule
  3. MAJOR TileChest.java#L757: Remove this expression which always evaluates to "true" rule
  4. MINOR TileChest.java#L260: Replace the type specification in this constructor call with the diamond operator ("<>"). rule
  5. MINOR TileChest.java#L263: Replace the type specification in this constructor call with the diamond operator ("<>"). rule
  6. MINOR TileChest.java#L676: Redundant 'public' modifier. rule

@fscan fscan added this to the rv6.alpha - 1.12 milestone Jul 25, 2018

@fscan fscan merged commit e5f43bf into rv6-1.12 Jul 31, 2018

3 of 4 checks passed

sonarqube SonarQube reported 8 issues, with 1 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the fix-chest branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment