Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fluid parts item models #3676

Merged
merged 1 commit into from Aug 29, 2018
Merged

Fix fluid parts item models #3676

merged 1 commit into from Aug 29, 2018

Conversation

@fscan
Copy link
Member

@fscan fscan commented Aug 11, 2018

No description provided.

@orod-org
Copy link

@orod-org orod-org commented Aug 11, 2018

SonarQube analysis reported 11 issues

  • BLOCKER 1 blocker
  • CRITICAL 2 critical
  • MAJOR 8 major

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. BLOCKER PartSharedStorageBus.java#: Add or update the header of this file. rule
  2. CRITICAL PartFluidStorageBus.java#L279: The Cyclomatic Complexity of this method "getInternalHandler" is 15 which is greater than 10 authorized. rule
  3. CRITICAL PartFluidStorageBus.java#L326: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. MAJOR PartFluidStorageBus.java#L216: Either log or rethrow this exception. rule
  5. MAJOR PartFluidStorageBus.java#L273: Either log or rethrow this exception. rule
  6. MAJOR PartFluidStorageBus.java#L286: Move the declaration of "wasSleeping" closer to the code that uses it. rule
  7. MAJOR PartFluidStorageBus.java#L364: Either log or rethrow this exception. rule
  8. MAJOR PartFluidStorageBus.java#L375: Either log or rethrow this exception. rule
  9. MAJOR PartFluidStorageBus.java#L401: Remove this expression which always evaluates to "true" rule
  10. MAJOR PartFluidStorageBus.java#L404: This block of commented-out lines of code should be removed. rule
@fscan fscan added this to the rv6.alpha - 1.12 milestone Aug 11, 2018
@yueh yueh merged commit d439fb2 into rv6-1.12 Aug 29, 2018
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@orod-org
sonarqube SonarQube reported 11 issues, with 2 critical and 1 blocker
continuous-integration/travis-ci/push The Travis CI build passed
Details
@yueh
jenkins Success
Details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
@yueh yueh deleted the fix-fluid-part-textures branch Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants