New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JEI to differentiate between different cable facades #3750

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@mezz
Contributor

mezz commented Sep 30, 2018

I occasionally get issues related to hiding AE cable facades in JEI, because JEI does not understand how to differentiate between different facades.

This PR lets JEI understand how to tell the difference between facades.
This does not impact looking up the recipes for facades in JEI.
I also bumped the dev version of JEI to the latest version, but it is not necessary for this.

Related JEI issues:
mezz/JustEnoughItems#1256
mezz/JustEnoughItems#1291
mezz/JustEnoughItems#1346

@covers1624

This comment has been minimized.

Member

covers1624 commented Oct 1, 2018

Failure seems to only be related to SonarQue bot.

@yueh yueh added this to the rv6.stable - 1.12 milestone Oct 1, 2018

@yueh

This comment has been minimized.

Member

yueh commented Oct 1, 2018

Yes, travis does not set the required envvars for an external PR. A bit annoying as I would have to disable them (if possible), but that also makes it somewhat useless.

@yueh yueh merged commit 7a5b84c into AppliedEnergistics:rv6-1.12 Oct 1, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
jenkins Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment