New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input P2P tunnels can now be assigned a new frequency. #3765

Merged
merged 1 commit into from Oct 21, 2018

Conversation

Projects
None yet
1 participant
@yueh
Member

yueh commented Oct 6, 2018

Shift right clicking an existing tunnel only allowed to copied the
stored frequency.

When shift right clicking now and the stored frequency being the same as
already stored one, it will now create a new one and save it to the memory
card. In other words doubling clicking will reset now, otherwise the old
behaviour is still kept.

Input P2P tunnels can now be assigned a new frequency.
Shift right clicking an existing tunnel only allowed to copied the
stored frequency.

When shift right clicking now and the stored frequency being the same as
already stored one, it will now create a new one and save it to the memory
card. In other words doubling clicking will reset now, otherwise the old
behaviour is still kept.

@yueh yueh added this to the rv6.stable - 1.12 milestone Oct 6, 2018

@sonarcloud

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

See all issues in SonarCloud

@sonarcloud

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

See all issues in SonarCloud

{
if( player.isSneaking() )
{
if( !w.isRemote )

This comment has been minimized.

@sonarcloud

sonarcloud bot Oct 6, 2018

Code Smell Code Smell: Merge this if statement with the enclosing one. (squid:S1066)

See it in SonarCloud

@Override
public boolean doesSneakBypassUse( final ItemStack itemstack, final IBlockAccess world, final BlockPos pos, final EntityPlayer player )
{
return true;
}
private void clearCard( final EntityPlayer player, final World w, final EnumHand hand )

This comment has been minimized.

@sonarcloud

sonarcloud bot Oct 6, 2018

Code Smell Code Smell: Remove this unused method parameter "w". (squid:S1172)

See it in SonarCloud

@@ -29,6 +29,7 @@
InvalidMachine,
LoadedSettings,
SavedSettings,
ResetSettings,

This comment has been minimized.

@sonarcloud

sonarcloud bot Oct 6, 2018

Code Smell Code Smell: Rename this constant name to match the regular expression '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'. (squid:S00115)

See it in SonarCloud

@yueh yueh merged commit 416c7d2 into rv6-1.12 Oct 21, 2018

3 of 4 checks passed

SonarCloud 3 Open Issues; 0.0% New code coverage; 0.4% Est. post-merge coverage
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@yueh yueh deleted the feature-p2p-memory-card-reset branch Oct 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment