Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3790: Correctly serialise fluids with NBT data. #3791

Merged
merged 2 commits into from Oct 21, 2018
Merged

Fixes #3790: Correctly serialise fluids with NBT data. #3791

merged 2 commits into from Oct 21, 2018

Conversation

@yueh
Copy link
Member

@yueh yueh commented Oct 19, 2018

No description provided.

@yueh yueh added this to the rv6.stable - 1.12 milestone Oct 19, 2018
Copy link

@sonarcloud sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

is.tag = this.tagCompound.copy();
}
final int amount = (int) Math.min( Integer.MAX_VALUE, this.getStackSize() );
final FluidStack is = new FluidStack( this.fluid, amount, this.tagCompound );

This comment has been minimized.

@sonarcloud

sonarcloud bot Oct 20, 2018

Code Smell Code Smell: Immediately return this expression instead of assigning it to the temporary variable "is". (squid:S1488)

See it in SonarCloud

@yueh yueh merged commit 99fd5a9 into rv6-1.12 Oct 21, 2018
3 of 4 checks passed
3 of 4 checks passed
@sonarcloud
SonarCloud 1 Open Issue; 0.0% New code coverage; 0.4% Est. post-merge coverage
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@yueh
jenkins Success
Details
@yueh yueh deleted the fix-3790 branch Oct 21, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant