Fixing No 3D at ToolColorApplicator #383

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@TheJulianJES
Contributor

TheJulianJES commented Nov 3, 2014

No description provided.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Nov 5, 2014

Member

Just wondered, why only the color applicator?

Member

thatsIch commented Nov 5, 2014

Just wondered, why only the color applicator?

@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES Nov 5, 2014

Contributor

I think it appears only on the Color Applicator?
It is other hold in F5.

Contributor

TheJulianJES commented Nov 5, 2014

I think it appears only on the Color Applicator?
It is other hold in F5.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Nov 12, 2014

Member

ok finally got my IDE running to check that. Its better to pull it into the AERootPoweredItem class and disable it in the ToolPortableCell because that looks just wrong xD but besides that, I approve.

Member

thatsIch commented Nov 12, 2014

ok finally got my IDE running to check that. Its better to pull it into the AERootPoweredItem class and disable it in the ToolPortableCell because that looks just wrong xD but besides that, I approve.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Nov 12, 2014

Member

And to reason why its better to pull it into the base class, the other tools look weird too, but maybe you just dont use it on regular basis to judge that :P

Member

thatsIch commented Nov 12, 2014

And to reason why its better to pull it into the base class, the other tools look weird too, but maybe you just dont use it on regular basis to judge that :P

@thatsIch thatsIch added this to the rv2 milestone Nov 12, 2014

@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES Nov 12, 2014

Contributor

Okay, probaly I will "fix" all tools and items. I will create a PR later.

Contributor

TheJulianJES commented Nov 12, 2014

Okay, probaly I will "fix" all tools and items. I will create a PR later.

@thatsIch

This comment has been minimized.

Show comment
Hide comment
@thatsIch

thatsIch Nov 17, 2014

Member

if you are already on it poke ^^

Member

thatsIch commented Nov 17, 2014

if you are already on it poke ^^

@Cisien

This comment has been minimized.

Show comment
Hide comment
@Cisien

Cisien Nov 26, 2014

Contributor

@TheJulianJES Are you still planning on updating the other tools?

Contributor

Cisien commented Nov 26, 2014

@TheJulianJES Are you still planning on updating the other tools?

@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES Nov 26, 2014

Contributor

Yeah, I already did it but I messed up my GitHub... I will fix it and then create a new pull request.

Contributor

TheJulianJES commented Nov 26, 2014

Yeah, I already did it but I messed up my GitHub... I will fix it and then create a new pull request.

@TheJulianJES

This comment has been minimized.

Show comment
Hide comment
@TheJulianJES

TheJulianJES Nov 26, 2014

Contributor

See #497

Contributor

TheJulianJES commented Nov 26, 2014

See #497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment