Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing No 3D at ToolColorApplicator #383

Closed
wants to merge 1 commit into from

Conversation

@TheJulianJES
Copy link
Contributor

TheJulianJES commented Nov 3, 2014

No description provided.

@thatsIch
Copy link
Member

thatsIch commented Nov 5, 2014

Just wondered, why only the color applicator?

@TheJulianJES
Copy link
Contributor Author

TheJulianJES commented Nov 5, 2014

I think it appears only on the Color Applicator?
It is other hold in F5.

@thatsIch
Copy link
Member

thatsIch commented Nov 12, 2014

ok finally got my IDE running to check that. Its better to pull it into the AERootPoweredItem class and disable it in the ToolPortableCell because that looks just wrong xD but besides that, I approve.

@thatsIch
Copy link
Member

thatsIch commented Nov 12, 2014

And to reason why its better to pull it into the base class, the other tools look weird too, but maybe you just dont use it on regular basis to judge that :P

@thatsIch thatsIch added this to the rv2 milestone Nov 12, 2014
@TheJulianJES
Copy link
Contributor Author

TheJulianJES commented Nov 12, 2014

Okay, probaly I will "fix" all tools and items. I will create a PR later.

@thatsIch
Copy link
Member

thatsIch commented Nov 17, 2014

if you are already on it poke ^^

@Cisien
Copy link
Contributor

Cisien commented Nov 26, 2014

@TheJulianJES Are you still planning on updating the other tools?

@TheJulianJES
Copy link
Contributor Author

TheJulianJES commented Nov 26, 2014

Yeah, I already did it but I messed up my GitHub... I will fix it and then create a new pull request.

@TheJulianJES
Copy link
Contributor Author

TheJulianJES commented Nov 26, 2014

See #497

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.