Added P2P tunnel part for OpenComputers. #579
Conversation
|
I would consider the API and localization currently under lockdown until it is finally merged. Otherwise it just makes things more complicated. The code style does not look like it is matching our. |
|
Made the requested changes.
Any ETA on that? Just so I know whether to keep my hacky third-party implementation in OC itself for now. |
|
resync please |
|
Cool, done! Also re-tested for good measure. |
| { | ||
|
|
||
| public static OC instance; | ||
|
|
thatsIch
Dec 13, 2014
Member
whats the point of this variable? I dont see any usage on it, be it writing nor reading
whats the point of this variable? I dont see any usage on it, be it writing nor reading
fnuecke
Dec 14, 2014
Author
Contributor
I just copied the RF module and adjusted that, it also has that variable. I assumed it'd be something filled in by the integration system. Will remove.
I just copied the RF module and adjusted that, it also has that variable. I assumed it'd be something filled in by the integration system. Will remove.
|
Looks fine to me, if you redo the import orders. |
Ah, missed that, importing the code style only showed XML files, so I just oriented myself on other files for the import order. Will take a look. |
|
Updated. |
|
Aaand, the one time I push while testing it and not after it breaks... the |
|
|
||
| BetterStorage(IntegrationSide.BOTH, "BetterStorage", "betterstorage" ), | ||
|
|
||
| OC(IntegrationSide.BOTH, "OpenComputers", "OpenComputers"); | ||
|
|
thatsIch
Dec 16, 2014
Member
Maybe its better to use a better qualified name here so it will not clash in the future
Suggestion: use OpenComputers as enum value
Maybe its better to use a better qualified name here so it will not clash in the future
Suggestion: use OpenComputers as enum value
fnuecke
Dec 16, 2014
Author
Contributor
Done.
Done.
|
We will pull it into the rv3 branch |
|
we would pull this into rv3 now, Else I can do the rabase on it. |
Adds tag and release shield
|
Great! I'll update it to the current state of the rv2 branch and check if it's still working. |
|
rebase it against the master (this will be the future rv3) |
Fixes #1405: Adds mcmod.info and pack.mcmeta to resources
|
Oops, messed that up. Will make a new PR against master. |
|
welcome to github :D |
|
Haha, yeah. I pretty much expected that to horribly fail, admittedly :P |
As discussed with @FireBall1725 on IRC, here's a PR adding a P2P tunnel part for OpenComputers networking.
Tested with and without OC, in dev-env and normal MC via vanilla launcher.
One thing that needs specific review are the adjusted enums. I believe the ones where I did not append the entry to the end to be order irrelevant, but verification of that is needed.