Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added P2P tunnel part for OpenComputers. #579

Closed
wants to merge 6 commits into from
Closed

Added P2P tunnel part for OpenComputers. #579

wants to merge 6 commits into from

Conversation

@fnuecke
Copy link
Contributor

@fnuecke fnuecke commented Dec 11, 2014

As discussed with @FireBall1725 on IRC, here's a PR adding a P2P tunnel part for OpenComputers networking.

Tested with and without OC, in dev-env and normal MC via vanilla launcher.

One thing that needs specific review are the adjusted enums. I believe the ones where I did not append the entry to the end to be order irrelevant, but verification of that is needed.

@yueh
Copy link
Member

@yueh yueh commented Dec 11, 2014

I would consider the API and localization currently under lockdown until it is finally merged. Otherwise it just makes things more complicated.

The code style does not look like it is matching our.
For example we do not prefix fields with _ (this is not PHP or Python and missing visibility), the import order is wrong and is there a reason why you are using fqdns for the classes?

@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented Dec 11, 2014

Made the requested changes.

I would consider the API and localization currently under lockdown until it is finally merged.

Any ETA on that? Just so I know whether to keep my hacky third-party implementation in OC itself for now.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Dec 13, 2014

resync please

@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented Dec 13, 2014

Cool, done! Also re-tested for good measure.

{

public static OC instance;

This comment has been minimized.

@thatsIch

thatsIch Dec 13, 2014
Member

whats the point of this variable? I dont see any usage on it, be it writing nor reading

This comment has been minimized.

@fnuecke

fnuecke Dec 14, 2014
Author Contributor

I just copied the RF module and adjusted that, it also has that variable. I assumed it'd be something filled in by the integration system. Will remove.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Dec 13, 2014

Looks fine to me, if you redo the import orders. codeformat/consistent.importorder has a priority list map

@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented Dec 14, 2014

consistent.importorder

Ah, missed that, importing the code style only showed XML files, so I just oriented myself on other files for the import order. Will take a look.

@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented Dec 14, 2014

Updated.

@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented Dec 14, 2014

Aaand, the one time I push while testing it and not after it breaks... the instance field seems to be required. Doesn't work if I remove it (so I added it back).


BetterStorage(IntegrationSide.BOTH, "BetterStorage", "betterstorage" ),

OC(IntegrationSide.BOTH, "OpenComputers", "OpenComputers");

This comment has been minimized.

@thatsIch

thatsIch Dec 16, 2014
Member

Maybe its better to use a better qualified name here so it will not clash in the future

Suggestion: use OpenComputers as enum value

This comment has been minimized.

@fnuecke

fnuecke Dec 16, 2014
Author Contributor

Done.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented Dec 16, 2014

We will pull it into the rv3 branch

@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 5, 2015

we would pull this into rv3 now,
not sure if anything particular new was added on your side.

Else I can do the rabase on it.

thatsIch and others added 2 commits May 5, 2015
thatsIch
Adds tag and release shield
@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented May 6, 2015

Great! I'll update it to the current state of the rv2 branch and check if it's still working.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 6, 2015

rebase it against the master (this will be the future rv3)

thatsIch and others added 3 commits May 7, 2015
Fixes #1405: Adds mcmod.info and pack.mcmeta to resources
@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented May 7, 2015

Oops, messed that up. Will make a new PR against master.

@thatsIch
Copy link
Member

@thatsIch thatsIch commented May 7, 2015

welcome to github :D

@fnuecke
Copy link
Contributor Author

@fnuecke fnuecke commented May 7, 2015

Haha, yeah. I pretty much expected that to horribly fail, admittedly :P

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants