Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incompatible config for React Native Versions >= 0.69.X #434

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

princefishthrower
Copy link
Contributor

As the title states, this fixes warnings introduced for all react native versions greater than or equal to 0.69

This issue was brought up in both #421 and #395 but both were mysteriously closed.

@amit-kremer93
Copy link
Contributor

@princefishthrower thank you for your MR! we still need to check if this fix has any impact on previous version of react native

@alexborton
Copy link

Is this going to be merged? This is an issue in RN 69 +

@amit-kremer93
Copy link
Contributor

We will update about ETA for this fix

@riteshsingh1
Copy link

any update on this? This issue is in RN 69 as well as in 70

@roryf
Copy link

roryf commented Mar 7, 2023

@amit-kremer93 still an issue in 0.71, first output from metro is

warn Package react-native-appsflyer contains invalid configuration: "dependency.platforms.ios.podspecPath" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.

@maulik54e
Copy link

Any updates on this when this will get approval & merged in ..?

@herbertfuchs
Copy link

any updates on this one guys? Metrics being affected here in 0.71 :(

@Tguntenaar
Copy link

Please merge this PR

@Darex1991
Copy link

Please merge :)

@renanbronchart
Copy link

Please possible to merge it? @0xJoelero @maulik54e @griarman ?

@maulik54e
Copy link

Please possible to merge it? @0xJoelero @maulik54e @griarman ?

i'm just package user same as you

Copy link

@Darex1991 Darex1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@professorkolik
Copy link

@liaz-af any chance you can merge and release this PR 🙏 ?

@Matiassimone
Copy link

Simple workaround until this PR is merged
#395 (comment)

@mina4gerges
Copy link

any updates ?

@joaquinvaz
Copy link

Hello, any updates on this?

@mrsasuuBeast
Copy link

Any updates?

1 similar comment
@YohayBar
Copy link

YohayBar commented Nov 6, 2023

Any updates?

Copy link

@zara-khaliq zara-khaliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates?

@markui
Copy link

markui commented Dec 9, 2023

Any updates? why is the appsflyer react native team not working towards this issue nor answering anything.

@alexandermendes
Copy link

While I agree it's annoying that this repository is apparently not being maintained constantly posting "any updates" is pointless. The answer is clearly no. And for those of us watching these threads we get spammed with such comments, or people clicking approve, just to click through and find nothing useful.

Considering this is ultimately a product that many people/businesses are paying for maybe we should all spam AppsFlyer customer services instead 🤷‍♂️

@mikypilota
Copy link

@af-fess @amit-kremer93 Hey, what's preventing this from getting merged in? We have a bunch of community reviews here, looks like a quick win to me.

@amit-kremer93 amit-kremer93 changed the base branch from master to development February 13, 2024 14:01
@amit-kremer93 amit-kremer93 merged commit 6f0032d into AppsFlyerSDK:development Feb 13, 2024
@Darex1991
Copy link

Nooo way O.o 1Y waiting, nice 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet