Work around server reloading issues #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #157. This was a really tricky bug and I still don't fully understand why it happens. My comments in the issue detail the investigation; this one in particular provides a minimal example which explains the changes in this PR.
In short, it seems that two things must be true about the
server
passed toshinyApp()
for reloading to work properly:function(input, output) { module_server("app") }
and notfunction(input, output) module_server("app")
).keep.source = TRUE
.How to test
Initialize a fresh project and run it with
shiny::runApp()
. Add some changes in the server ofmain.R
, e.g. change the "Hello!" string. It should be sufficient totouch app.R
(update its timestamp) and refresh the page in the browser to see the changes.