From f850911871408b724f64c4d2e7b42220ab57ed7e Mon Sep 17 00:00:00 2001 From: Jakub Sobolewski <37193264+jakubsob@users.noreply.github.com> Date: Thu, 16 May 2024 15:38:42 +0200 Subject: [PATCH] Preparation for CRAN release (#82) * chore: update NEWS.md * chore: update maintainer info * chore: add cran-comments.md --------- Co-authored-by: Jakub Sobolewski --- .Rbuildignore | 1 + DESCRIPTION | 4 ++-- NEWS.md | 6 ++++++ cran-comments.md | 5 +++++ 4 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 cran-comments.md diff --git a/.Rbuildignore b/.Rbuildignore index 77338fc..09d3645 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -15,3 +15,4 @@ ^js$ _\.new\.png$ +^cran-comments\.md$ diff --git a/DESCRIPTION b/DESCRIPTION index 7902a5d..3fd7882 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -3,8 +3,8 @@ Title: Tools for Using React in Shiny Version: 0.4.0 Authors@R: c( - person("Kamil", "Żyła", role = c("aut", "cre"), email = "opensource+kamil@appsilon.com"), - person("Jakub", "Sobolewski", role = "aut", email = "jakub.sobolewski@appsilon.com"), + person("Jakub", "Sobolewski", role = c("aut", "cre"), email = "opensource+jakub.sobolewski@appsilon.com"), + person("Kamil", "Żyła", role = "aut", email = "kamil@appsilon.com"), person("Marek", "Rogala", role = "aut", email = "marek@appsilon.com"), person("Appsilon Sp. z o.o.", role = "cph", email = "opensource@appsilon.com") ) diff --git a/NEWS.md b/NEWS.md index 09ec7d0..26f4f4f 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,9 @@ +# shiny.react 0.4.0 + +- Upgrade React to 18.3.1: + - Replace deprecated React API. React 18 deprecates (React 19 removes) `ReactDOM.render` and `ReactDOM.unmountComponentAtNode`. `ReactDOM.createRoot` is used in place of those functions according to the [React 19 migration guide](https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-dom-apis). + - Changed rendering mechanism of React components. This change is motivated by the fact that it's impossible to call `ReactDOM.createRoot` on a container more than one time while `ReactDOM.render` allowed that. A `data-react-id` attribute is used to find and render React roots in place iterating over all nodes with `.react-data` class. + # shiny.react 0.3.0 1. Render React asynchronously and only once Shiny is fully initialized: diff --git a/cran-comments.md b/cran-comments.md new file mode 100644 index 0000000..27fcf40 --- /dev/null +++ b/cran-comments.md @@ -0,0 +1,5 @@ +## Author comment + +Submission of this version of the package breaks shiny.fluent and shiny.blueprint packages which depend on shiny.react due to the React upgrade. + +The submission of shiny.react 0.4.0 will be followed by a submissions of shiny.fluent and shiny.blueprint, which will address compatibility issues.